Bug #93636 for DBD-Pg: Dollar Quoting is being triggered in the middle of a identifier

Fri Mar 07 17:29:35 2014 https://www.google.com/accounts/o8/id?id=AItOawnSsPo273KfpodNC5_8ief8Zr4STOvh74s - Ticket created

Subject:

Dollar Quoting is being triggered in the middle of a identifier

An identifier containing a pair of dollar signs triggers the dollar quote handling in pg_st_split_statement, which can consume the rest of the SQL statement and trigger a secondary error of no placeholders being found. Example: $dbh->do('SELECT tablename AS alt$identifier$test FROM pg_tables WHERE tablename = ?', { }, ''); Error: DBD::Pg::db do failed: called with 1 bind variables when 0 are needed at dbq.pl line 5. Tugrul Galatali

Fri Mar 07 21:12:30 2014 greg [...] turnstep.com - Taken

Fri Mar 07 21:28:18 2014 greg [...] turnstep.com - Correspondence added

Ugh, why would you ever want to create a name like that? :) We will look into this.

Fri Mar 07 21:28:19 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 07 21:30:53 2014 greg [...] turnstep.com - Correspondence added

Off the top of my head, I can't see us adding a whole lot more parsing brains into DBD::Pg when there is an easy workaround - putting the name in double quotes: $dbh->do(q{SELECT tablename AS "alt$identifier$test" FROM pg_tables WHERE tablename = ?}, { }, 'foobar');

Fri Mar 07 23:01:55 2014 https://www.google.com/accounts/o8/id?id=AItOawnSsPo273KfpodNC5_8ief8Zr4STOvh74s - Correspondence added

Fair enough. However it would be nice if there was a more appropriate error. I didn't even know about dollar quoting until I went digging into the DBD::Pg code. Maybe a warning if the closing dollar quote isn't found? Also a note in the documentation.

Wed Apr 02 18:14:40 2014 greg [...] turnstep.com - Correspondence added

Show quoted text

> Maybe a warning if the closing dollar quote isn't found? Also a note > in the documentation.

No, because it could still be a valid query if the closing dollar isn't found. The idea is to pass things off to the Postgres parser and let them throw the error. It's unfortunate that happens on first execute and not prepare, but I don't see a clean way around that.

Wed May 21 06:04:41 2014 greg [...] turnstep.com - Correspondence added

Stalling for now

Wed May 21 06:04:44 2014 greg [...] turnstep.com - Status changed from 'open' to 'stalled'

Fri Dec 19 05:46:17 2014 TIMB [...] cpan.org - Correspondence added

Statements that might contain unusual identifiers should be constructed using the quote_identifier method. I think this issue could be closed now.

Fri Dec 19 05:46:18 2014 The RT System itself - Status changed from 'stalled' to 'open'

Sun Apr 02 20:08:45 2017 greg [...] turnstep.com - Correspondence added

Closing this.

Sun Apr 02 20:08:51 2017 greg [...] turnstep.com - Status changed from 'open' to 'rejected'