Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Sereal-Decoder CPAN distribution.

Report information
The Basics
Id: 93607
Status: open
Priority: 0/
Queue: Sereal-Decoder
People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Mar 07 07:46:35 2014 zefram [...] fysh.org - Ticket created
Subject: refcount broken in undocumented functions
Date: Fri, 7 Mar 2014 12:46:21 +0000
To: bug-Sereal-Decoder [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
The undocumented decode_with_header{,_and_offset} functions screw up the refcount of the elements being put into the returned array. av_store takes ownership of one counted reference, but the code doesn't increment the refcount for that purpose. -zefram
  Fri Mar 07 08:39:35 2014 demerphq [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #93607] refcount broken in undocumented functions
Date: Fri, 7 Mar 2014 14:39:24 +0100
To: bug-Sereal-Decoder [...] rt.cpan.org
From: demerphq <demerphq [...] gmail.com>
On 7 March 2014 13:46, Zefram via RT <bug-Sereal-Decoder@rt.cpan.org> wrote: Show quoted text
> Fri Mar 07 07:46:35 2014: Request 93607 was acted upon. > Transaction: Ticket created by zefram@fysh.org > Queue: Sereal-Decoder > Subject: refcount broken in undocumented functions > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: zefram@fysh.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=93607 > > > > The undocumented decode_with_header{,_and_offset} functions screw > up the refcount of the elements being put into the returned array. > av_store takes ownership of one counted reference, but the code doesn't > increment the refcount for that purpose.
Fix pushed as 1c1ac37b0709630832634d4ffd27d4431ea8b285. If you have a test for this a patch would be welcomed. Yves -- perl -Mre=debug -e "/just|another|perl|hacker/"
  Fri Mar 07 08:39:35 2014 The RT System itself - Status changed from 'new' to 'open'