Skip Menu |

This queue is for tickets about the App-FatPacker CPAN distribution.

Report information
The Basics
Id: 93578
Status: open
Priority: 0/
Queue: App-FatPacker

People
Owner: Nobody in particular
Requestors: tsibley [...] cpan.org
VTI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Fails finding modules when .packlist contains relative paths (patch included)
--- FatPacker.pm 2013-11-27 23:25:58.000000000 +0200 +++ FatPacker.pm 2014-03-06 21:05:40.000000000 +0200 @@ -151,7 +151,7 @@ no_chdir => 1, wanted => sub { return unless /[\\\/]\.packlist$/ && -f $_; - $pack_rev{$_} = $File::Find::name for lines_of $File::Find::name; + $pack_rev{Cwd::realpath($_)} = $File::Find::name for lines_of $File::Find::name; }, }, @search); my %found; @found{map +($pack_rev{Cwd::abs_path($INC{$_})}||()), @targets} = (); @@ -181,6 +181,7 @@ } die "Couldn't figure out base path of packlist ${pl}" unless $pack_base; foreach my $source (lines_of $pl) { + $source = Cwd::realpath($source); # there is presumably a better way to do "is this under this base?" # but if so, it's not obvious to me in File::Spec next unless substr($source,0,length $pack_base) eq $pack_base;
This patch seems useful. -- Olivier Mengué - http://perlresume.org/DOLMEN
I've been bitten by this. Any chance of applying the patch?
On 2014-10-13 20:09:31, TSIBLEY wrote: Show quoted text
> I've been bitten by this. Any chance of applying the patch?
I'm looking at this and wondering how to write a test that exercises this? We don't seem to explicitly making use of the packlist anywhere in tests.
Subject: Re: [rt.cpan.org #93578] Fails finding modules when .packlist contains relative paths (patch included)
Date: Sat, 18 Oct 2014 23:27:13 -0700
To: bug-App-FatPacker [...] rt.cpan.org
From: Thomas Sibley <tsibley [...] cpan.org>
On 10/18/2014 11:22 PM, Karen Etheridge via RT wrote: Show quoted text
> I'm looking at this and wondering how to write a test that exercises > this? We don't seem to explicitly making use of the packlist > anywhere in tests.
It seems you could write a test that mocked up a packlist, then called App::FatPacker->packlists_to_tree($tmpdir, [$packlist]), and finally inspected the tree to see if the relative paths in the given packlist were copied to the tree correctly.