Skip Menu |

This queue is for tickets about the RTx-TicketlistTransactions CPAN distribution.

Report information
The Basics
Id: 93547
Status: resolved
Priority: 0/
Queue: RTx-TicketlistTransactions
People
Owner: cpan [...] jibsheet.com
Requestors: cloos [...] netcologne.de
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed Mar 05 10:35:45 2014 cloos [...] netcologne.de - Ticket created
Subject: LastTransactionContent not in Display Columns
Date: Wed, 05 Mar 2014 16:35:36 +0100
To: bug-RTx-TicketlistTransactions [...] rt.cpan.org
From: Christian Loos <cloos [...] netcologne.de>
Hi, html/Callbacks/RTx-TicketlistTransactions/Search/Elements/BuildFormatString/SetFieldsOnce add the new LastTransactionContent column to the 'Display Columns' select on Search/Build.html. But LastTransactionContent is only in the 'Display Columns' select on the first Search/Build.html page load after a webserver restart. If you then reload the Search/Build.html page the LastTransactionContent isn't in the 'Display Columns' select any more. I think the reason for this is that the SetFieldsOnce callback in share/html/Search/Elements/BuildFormatString have CallbackOnce set to 1. Maybe using the default callback and check if Fields already contains LastTransactionContent could fix this. Chris
  Wed Mar 05 15:42:13 2014 falcone [...] bestpractical.com - Correspondence added
Subject: Re: [rt.cpan.org #93547] LastTransactionContent not in Display Columns
Date: Wed, 5 Mar 2014 15:42:11 -0500
To: "cloos [...] netcologne.de via RT" <bug-RTx-TicketlistTransactions [...] rt.cpan.org>
From: Kevin Falcone <falcone [...] bestpractical.com>
On Wed, Mar 05, 2014 at 10:35:46AM -0500, cloos@netcologne.de via RT wrote: Show quoted text
> But LastTransactionContent is only in the 'Display Columns' select on > the first Search/Build.html page load after a webserver restart. If you > then reload the Search/Build.html page the LastTransactionContent isn't > in the 'Display Columns' select any more. > > I think the reason for this is that the SetFieldsOnce callback in > share/html/Search/Elements/BuildFormatString have CallbackOnce set to 1.
We've seen this in another extension, apparently a regression of some kind with CallbackOnce (or perhaps with this component). It's a complicated piece of code (see the once vs init comment earlier in the file). Show quoted text
> Maybe using the default callback and check if Fields already contains > LastTransactionContent could fix this.
This is the solution we pursued in the other extension and I expect it'll work here. If you `mv SetFieldsOnce Default` does that fix it for you or do you start getting repeated fields? -kevin
  Wed Mar 05 15:42:14 2014 The RT System itself - Status changed from 'new' to 'open'
  Thu Mar 06 02:12:40 2014 cloos [...] netcologne.de - Correspondence added
Subject: Re: [rt.cpan.org #93547] LastTransactionContent not in Display Columns
Date: Thu, 06 Mar 2014 08:12:26 +0100
To: bug-RTx-TicketlistTransactions [...] rt.cpan.org
From: Christian Loos <cloos [...] netcologne.de>
Am 05.03.2014 21:42, schrieb falcone@bestpractical.com via RT: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=93547 > > > On Wed, Mar 05, 2014 at 10:35:46AM -0500, cloos@netcologne.de via RT wrote:
>> But LastTransactionContent is only in the 'Display Columns' select on >> the first Search/Build.html page load after a webserver restart. If you >> then reload the Search/Build.html page the LastTransactionContent isn't >> in the 'Display Columns' select any more. >> >> I think the reason for this is that the SetFieldsOnce callback in >> share/html/Search/Elements/BuildFormatString have CallbackOnce set to 1.
> > We've seen this in another extension, apparently a regression of some > kind with CallbackOnce (or perhaps with this component). It's a > complicated piece of code (see the once vs init comment earlier in the > file). >
>> Maybe using the default callback and check if Fields already contains >> LastTransactionContent could fix this.
> > This is the solution we pursued in the other extension and I expect > it'll work here. > > If you `mv SetFieldsOnce Default` does that fix it for you or do you > start getting repeated fields?
Rename the file fixed it. Surprisingly I don't get repeated fields, but I remember the last time I tried this I saw repeated fields. Tested now with RT 4.0.19 and RT 4.2.3 with fastcgi and modperl. Chris
  Thu Mar 06 11:06:18 2014 falcone [...] bestpractical.com - Correspondence added
Subject: Re: [rt.cpan.org #93547] LastTransactionContent not in Display Columns
Date: Thu, 6 Mar 2014 11:06:16 -0500
To: "cloos [...] netcologne.de via RT" <bug-RTx-TicketlistTransactions [...] rt.cpan.org>
From: Kevin Falcone <falcone [...] bestpractical.com>
On Thu, Mar 06, 2014 at 02:12:41AM -0500, cloos@netcologne.de via RT wrote: Show quoted text
> > If you `mv SetFieldsOnce Default` does that fix it for you or do you > > start getting repeated fields?
> > Rename the file fixed it. > Surprisingly I don't get repeated fields, but I remember the last time I > tried this I saw repeated fields. > Tested now with RT 4.0.19 and RT 4.2.3 with fastcgi and modperl.
Current working theory is that something changed in 3.8 and 4.0 (we redid the internals a lot there) and now there's a difference in the CallbackOnce code and this static list. I remember fixing 'repeated fields' bugs in 3.8, but we've used this same fix two other times in 4.2 and 4.0, so I'm likely to just ship it like this, especially since RT 3.8 only has 25 more days of support. I'll git mv this and tweak the Makefile and ship a new version this week. -kevin
  Fri Mar 07 16:25:05 2014 falcone [...] bestpractical.com - Correspondence added
Subject: Re: [rt.cpan.org #93547] LastTransactionContent not in Display Columns
Date: Fri, 7 Mar 2014 16:25:03 -0500
To: "falcone [...] bestpractical.com via RT" <bug-RTx-TicketlistTransactions [...] rt.cpan.org>
From: Kevin Falcone <falcone [...] bestpractical.com>
Show quoted text
> I remember fixing 'repeated fields' bugs in 3.8, but we've used this > same fix two other times in 4.2 and 4.0, so I'm likely to just ship it > like this, especially since RT 3.8 only has 25 more days of support.
This ended up being such an awesome bug that the description of the failure is too large for this email and I've made it into an rt.git commit instead. https://github.com/bestpractical/rt/commit/27af6e61bdf2b9a0b296ae959adf90bcd32b3d4d Show quoted text
> I'll git mv this and tweak the Makefile and ship a new version this > week.
Shipped 0.03 to CPAN -kevin
  Fri Mar 07 16:26:12 2014 cpan [...] jibsheet.com - Status changed from 'open' to 'resolved'
  Fri Mar 07 16:27:56 2014 cpan [...] jibsheet.com - Taken