Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Devel-PPPort CPAN distribution.

Report information
The Basics
Id: 93521
Status: resolved
Priority: 0/
Queue: Devel-PPPort

People
Owner: WolfSage [...] cpan.org
Requestors: ben [...] morrow.me.uk
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 3.25



Subject: [PATCH] Implement caller_cx
Date: Tue, 4 Mar 2014 18:14:23 +0000
To: bug-Devel-PPPort [...] rt.cpan.org
From: Ben Morrow <ben [...] morrow.me.uk>
The attached patch adds an implementation of caller_cx. I've tested it with various perls back to 5.6.0; I can't get any earlier perls to build (even with buildperl.pl: I get sed: -e: No such file or directory sed -i -e '/^.*<builtin>/d' -e '/^.*<built-in>/d' -e '/^.*<command Show quoted text
line>/d' -e '/^.*<command-line>/d' makefile x2p/makefile: 256
). Ben

Message body is not shown because sender requested not to inline it.

On Tue Mar 04 13:14:39 2014, ben@morrow.me.uk wrote: Show quoted text
> The attached patch adds an implementation of caller_cx. I've tested it > with various perls back to 5.6.0; I can't get any earlier perls to build > (even with buildperl.pl: I get > > sed: -e: No such file or directory > sed -i -e '/^.*<builtin>/d' -e '/^.*<built-in>/d' -e '/^.*<command
> line>/d' -e '/^.*<command-line>/d' makefile x2p/makefile: 256
> > ). > > Ben >
Thanks! If someone else doesn't get to this before me soon, I'll take a look at it in the next two-three weeks. -- Matthew Horsfall (alh)
On Tue Mar 04 13:14:39 2014, ben@morrow.me.uk wrote: Show quoted text
> (even with buildperl.pl: I get > > sed: -e: No such file or directory > sed -i -e '/^.*<builtin>/d' -e '/^.*<built-in>/d' -e '/^.*<command
> line>/d' -e '/^.*<command-line>/d' makefile x2p/makefile: 256
> > ).
Are you running this on a Mac? The Mac and GNU sed utilities are sadly incompatible. You might be luckier with a GNU sed.
Subject: Re: [rt.cpan.org #93521] [PATCH] Implement caller_cx
Date: Thu, 13 Mar 2014 08:06:46 +0000
To: MHX via RT <bug-Devel-PPPort [...] rt.cpan.org>
From: Ben Morrow <ben [...] morrow.me.uk>
At 8PM -0400 on 12/03/14 MHX wrote: Show quoted text
> On Tue Mar 04 13:14:39 2014, ben@morrow.me.uk wrote:
> > (even with buildperl.pl: I get > > > > sed: -e: No such file or directory > > sed -i -e '/^.*<builtin>/d' -e '/^.*<built-in>/d' -e '/^.*<command
> > line>/d' -e '/^.*<command-line>/d' makefile x2p/makefile: 256
> > > > ).
> > Are you running this on a Mac?
FreeBSD. Show quoted text
> The Mac and GNU sed utilities are sadly incompatible. You might > be luckier with a GNU sed.
While I could install gsed from ports, it gets installed as 'gsed' to avoid conflicting with the system sed, so that doesn't help much. If I fix the sed invocations I get prototype conflicts in malloc.c. I can make them go away by passing -Dccflags=-DHIDEMYMALLOC to Configure, but first the 'extracting symbols from libc' step fails and Configure fails to find any of the symbols it's looking for, and then compilation fails here: util.c: In function 'vsprintf': util.c:1408: error: argument 'pat' doesn't match prototype /usr/include/stdio.h:276: error: prototype declaration util.c:1408: error: argument 'args' doesn't match prototype /usr/include/stdio.h:276: error: prototype declaration util.c:1411: error: 'FILE' has no member named '_ptr' util.c:1412: error: 'FILE' has no member named '_cnt' util.c:1416: error: 'FILE' has no member named '_flag' util.c:1416: error: '_IOWRT' undeclared (first use in this function) I also get some worrying warnings about casting pointers to int (this is a 64bit machine). Obviously this isn't going to work without a fair amount of porting effort. Ben
I've added your patch with slight modifications ( shown here: https://github.com/mhx/Devel-PPPort/commit/b4b2c6277deb9e8a3eafc5e2cb44a78b33e597d3 and here https://github.com/mhx/Devel-PPPort/commit/3fafaba96472fc14b20c4555ce95193948f6d424 ). It's only supported as far back as 5.6.0, as there are issues before that. If that's good enough, I'd say we can close this ticket. If you want the support to go further back, let's keep this open (or move it to the github tracker) so we can figure out what to do. Thanks, -- Matthew Horsfall (alh)
Subject: Re: [rt.cpan.org #93521] [PATCH] Implement caller_cx
Date: Wed, 3 Dec 2014 16:53:40 +0000
To: Matthew Horsfall via RT <bug-Devel-PPPort [...] rt.cpan.org>
From: Ben Morrow <ben [...] morrow.me.uk>
Matthew Horsfall via RT <bug-Devel-PPPort@rt.cpan.org> wrote: Show quoted text
Looks good. Show quoted text
> It's only supported as far back as 5.6.0, as there are issues before that.
Yes; the cxstack was rather different before 5.6. I don't see any point going further back than that; 5.6 has not had even security fixes for many years, so anyone still using it is definitely on their own. Thank you for looking at this, Ben
On Wed Dec 03 11:54:04 2014, ben@morrow.me.uk wrote: Show quoted text
> Matthew Horsfall via RT <bug-Devel-PPPort@rt.cpan.org> wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=93521 > > > > > I've added your patch with slight modifications ( shown here: > > https://github.com/mhx/Devel-PPPort/commit/b4b2c627 > > and here > > https://github.com/mhx/Devel-PPPort/commit/3fafaba9 > > ).
> > Looks good. >
> > It's only supported as far back as 5.6.0, as there are issues before that.
> > Yes; the cxstack was rather different before 5.6. I don't see any point > going further back than that; 5.6 has not had even security fixes for > many years, so anyone still using it is definitely on their own. > > Thank you for looking at this, > Ben
Awesome. Thanks for the patch. Closing. (Released in 3.25)