Bug #93474 for Term-ANSIColor: t/pod.t fail

Sun Mar 02 15:54:33 2014 dsteinbrunner [...] pobox.com - Ticket created

Subject:

t/pod.t fail

I'm trying to install Term::ANSIColor on Mac OS X 10.6 with perl 5.10.0. I was getting this failure: t/pod.t .............. 1/2 # Failed test 'examples' # at /System/Library/Perl/Extras/5.10.0/Test/Pod.pm line 159. # examples does not exist # Looks like you failed 1 test of 2. t/pod.t .............. Dubious, test returned 1 (wstat 256, 0x100) I updated Test::Pod from 1.26 to 1.48 and the test passed. Tests should change to work with the older module, a dependency on a newer version of the module be put in place allows the test to pass and/or the test be skipped for non maintainer installs.

Mon Mar 03 11:38:07 2014 ether [...] cpan.org - Correspondence added

Pod tests are not appropriate to run for user installs. The test should be moved to xt/author/pod.t, or a guard placed at the top so that it only runs when $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING} is set.

Mon Mar 03 11:38:08 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Mar 03 15:31:33 2014 RRA [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #93474] t/pod.t fail
Date:	Mon, 03 Mar 2014 12:31:19 -0800
To:	bug-Term-ANSIColor [...] rt.cpan.org
From:	Russ Allbery <rra [...] cpan.org>

"Karen Etheridge via RT" <bug-Term-ANSIColor@rt.cpan.org> writes: Show quoted text

> Queue: Term-ANSIColor > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=93474 >

Show quoted text

> Pod tests are not appropriate to run for user installs. The test should > be moved to xt/author/pod.t, or a guard placed at the top so that it > only runs when $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING} is set.

Previously, I haven't agreed for the POD syntax check (I do agree for spelling checks). However, that was before a standardized way of including release tests was available, and if those tests are now run by the automated CPAN testers, I will reconsider. I do want the POD tests to be run by the automated CPAN testing process. Regardless, it does look like there needs to be a versioned dependency on Test::Pod that skips the test if the version isn't new enough. I plan on making that change in the next release. -- #!/usr/bin/perl -- Russ Allbery, Just Another Perl Hacker $^=q;@!>~|{>krw>yn{u<$$<[~||<Juukn{=,<S~|}<Jwx}qn{<Yn{u<Qjltn{ > 0gFzD gD, 00Fz, 0,,( 0hF 0g)F/=, 0> "L$/GEIFewe{,$/ 0C$~> "@=,m,|,(e 0.), 01,pnn,y{ rw} >;,$0=q,$,,($_=$^)=~y,$/ C-~><@=\n\r,-~$:-u/ #y,d,s,(\$.),$1,gee,print

Wed Mar 19 11:14:08 2014 dolmen [...] cpan.org - Correspondence added

Subject:	t/pod.t fails
RT-Send-CC:	RRA [...] cpan.org

Le 2014-03-03 21:31:33, RRA a écrit : Show quoted text

> Previously, I haven't agreed for the POD syntax check (I do agree for > spelling checks). However, that was before a standardized way of > including release tests was available, and if those tests are now run by > the automated CPAN testers, I will reconsider. I do want the POD tests to > be run by the automated CPAN testing process.

If what matters is only automated CPAN testing ("CPAN Testers") and author testing, you should have a look at the specification for environment variables available for testing, the so-called "Lancaster Consensus": https://github.com/Perl-Toolchain-Gang/toolchain-site/blob/master/lancaster-consensus.md#environment-variables-for-testing-contexts t/pod.t should only run if either AUTOMATED_TESTING, AUTHOR_TESTING or RELEASE_TESTING is set. I see that you use RRA_MAINTAINER_TESTS in other tests. You could use AUTHOR_TESTING or RELEASE_TESTING instead. -- Olivier Mengué - http://perlresume.org/DOLMEN

Wed Mar 19 11:15:54 2014 dolmen [...] cpan.org - Requestor DOLMEN added

Wed Mar 19 15:51:35 2014 RRA [...] cpan.org - Correspondence added

CC:	RRA [...] cpan.org
Subject:	Re: [rt.cpan.org #93474] t/pod.t fails
Date:	Wed, 19 Mar 2014 12:51:22 -0700
To:	bug-Term-ANSIColor [...] rt.cpan.org
From:	Russ Allbery <rra [...] cpan.org>

"Olivier Mengué via RT" <bug-Term-ANSIColor@rt.cpan.org> writes: Show quoted text

> If what matters is only automated CPAN testing ("CPAN Testers") and > author testing, you should have a look at the specification for > environment variables available for testing, the so-called "Lancaster > Consensus": > https://github.com/Perl-Toolchain-Gang/toolchain-site/blob/master/lancaster-consensus.md#environment-variables-for-testing-contexts

Show quoted text

> t/pod.t should only run if either AUTOMATED_TESTING, AUTHOR_TESTING or > RELEASE_TESTING is set.

Show quoted text

> I see that you use RRA_MAINTAINER_TESTS in other tests. You could use > AUTHOR_TESTING or RELEASE_TESTING instead.

Thanks! That was the piece of information that I was missing. I'll take a look at this, hopefully soon (but realistically probably not before this weekend, as work is being annoying at the moment). -- #!/usr/bin/perl -- Russ Allbery, Just Another Perl Hacker $^=q;@!>~|{>krw>yn{u<$$<[~||<Juukn{=,<S~|}<Jwx}qn{<Yn{u<Qjltn{ > 0gFzD gD, 00Fz, 0,,( 0hF 0g)F/=, 0> "L$/GEIFewe{,$/ 0C$~> "@=,m,|,(e 0.), 01,pnn,y{ rw} >;,$0=q,$,,($_=$^)=~y,$/ C-~><@=\n\r,-~$:-u/ #y,d,s,(\$.),$1,gee,print

Thu Mar 20 05:49:13 2014 dolmen [...] cpan.org - Correspondence added

Le 2014-03-19 20:51:35, RRA a écrit : Show quoted text

> Thanks! That was the piece of information that I was missing. I'll > take > a look at this, hopefully soon (but realistically probably not before > this > weekend, as work is being annoying at the moment).

Cool! Please check RT#94006 first as it links to a Git branch containing fixes for the build of this distribution. -- Olivier Mengué - http://perlresume.org/DOLMEN

Sun Mar 23 21:58:27 2014 RRA [...] cpan.org - Correspondence added

This should be fixed in 4.03, just now uploaded. The POD test is now skipped unless automated or release testing is done, and (as part of updating all of those tests to my current standard versions) the POD syntax test is no longer using the part of the Test::POD API that appears to have changed. Thanks for the report!

Sun Mar 23 21:58:29 2014 RRA [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Mar 23 21:58:29 2014 RRA [...] cpan.org - Taken