Bug #93121 for CPANPLUS-Dist-Fedora: requires vs buildrequires

Tue Feb 18 07:54:28 2014 chris.travers [...] gmail.com - Ticket created

Subject:	requires vs buildrequires
Date:	Tue, 18 Feb 2014 04:54:13 -0800
To:	bug-cpanplus-dist-fedora <bug-CPANPLUS-Dist-Fedora [...] rt.cpan.org>
From:	Chris Travers <chris.travers [...] gmail.com>

Hi; I was noticing that the spec file transforms required modules in the META file to buildrequires in the spec. This makes it impossible to build a module that can be distributed as it is (the spec must be tweaked). I would propose to either change the buildrequires directives to requires directives, or to both buildrequires and requires. This would make it easier to just use the module to create an rpm and distribute it. Would a patch to do this be of interest? Best wishes, Chris Travers -- Best Wishes, Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more.shtml

Tue Feb 18 08:17:11 2014 SHLOMIF [...] cpan.org - Correspondence added

Hi Chris, On Tue Feb 18 07:54:28 2014, EINHVERFR wrote: Show quoted text

> Hi; > > I was noticing that the spec file transforms required modules in the META > file to buildrequires in the spec. This makes it impossible to build a > module that can be distributed as it is (the spec must be tweaked). > > I would propose to either change the buildrequires directives to requires > directives, or to both buildrequires and requires.

That behaviour probably has its origin in the Mandriva origins of that module (originally written by Jerome Quelin, I believe), because Mandriva (and now Mageia) implicitly detects most of the Requires: for the .rpm after it was created using a hook. If Fedora does not do that automatically, then I recommend adding them to both the BuildRequires *and* the Requires. Show quoted text

> > This would make it easier to just use the module to create an rpm and > distribute it. > > Would a patch to do this be of interest?

Sure. Show quoted text

> > Best wishes, > Chris Travers >

Regards, -- Shlomi Fish

Tue Feb 18 08:17:12 2014 The RT System itself - Status changed from 'new' to 'open'

Tue Feb 18 08:24:39 2014 chris.travers [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #93121] requires vs buildrequires
Date:	Tue, 18 Feb 2014 05:24:29 -0800
To:	bug-cpanplus-dist-fedora <bug-CPANPLUS-Dist-Fedora [...] rt.cpan.org>
From:	Chris Travers <chris.travers [...] gmail.com>

Ok, I have updated pull request 1 to include both the patches. Let me know if you have any questions or there is anything I can do further. I hope to be using this for packaging fairly soon. Thanks again for a great package that saves me a bunch of work. On Tue, Feb 18, 2014 at 5:17 AM, Shlomi Fish via RT < bug-CPANPLUS-Dist-Fedora@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=93121 > > > Hi Chris, > > On Tue Feb 18 07:54:28 2014, EINHVERFR wrote:

> > Hi; > > > > I was noticing that the spec file transforms required modules in the META > > file to buildrequires in the spec. This makes it impossible to build a > > module that can be distributed as it is (the spec must be tweaked). > > > > I would propose to either change the buildrequires directives to requires > > directives, or to both buildrequires and requires.

> > That behaviour probably has its origin in the Mandriva origins of that > module (originally written by Jerome Quelin, I believe), because Mandriva > (and now Mageia) implicitly detects most of the Requires: for the .rpm > after it was created using a hook. If Fedora does not do that > automatically, then I recommend adding them to both the BuildRequires *and* > the Requires. >

> > > > This would make it easier to just use the module to create an rpm and > > distribute it. > > > > Would a patch to do this be of interest?

> > Sure. >

> > > > Best wishes, > > Chris Travers > >

> > Regards, > > -- Shlomi Fish > > >

-- Best Wishes, Chris Travers Efficito: Hosted Accounting and ERP. Robust and Flexible. No vendor lock-in. http://www.efficito.com/learn_more.shtml

Tue Feb 18 09:18:37 2014 SHLOMIF [...] cpan.org - Correspondence added

Hi, I applied the patches in version 0.0.5, which I have just uploaded to CPAN. So I'm RESOLVEing it for now. Regards, -- Shlomi Fish On Tue Feb 18 08:24:39 2014, EINHVERFR wrote: Show quoted text

> Ok, I have updated pull request 1 to include both the patches. > > Let me know if you have any questions or there is anything I can do > further. I hope to be using this for packaging fairly soon. > > Thanks again for a great package that saves me a bunch of work. > > > On Tue, Feb 18, 2014 at 5:17 AM, Shlomi Fish via RT < > bug-CPANPLUS-Dist-Fedora@rt.cpan.org> wrote: >

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=93121 > > > > > Hi Chris, > > > > On Tue Feb 18 07:54:28 2014, EINHVERFR wrote:

> > > Hi; > > > > > > I was noticing that the spec file transforms required modules in > > > the META > > > file to buildrequires in the spec. This makes it impossible to > > > build a > > > module that can be distributed as it is (the spec must be tweaked). > > > > > > I would propose to either change the buildrequires directives to > > > requires > > > directives, or to both buildrequires and requires.

> > > > That behaviour probably has its origin in the Mandriva origins of > > that > > module (originally written by Jerome Quelin, I believe), because > > Mandriva > > (and now Mageia) implicitly detects most of the Requires: for the > > .rpm > > after it was created using a hook. If Fedora does not do that > > automatically, then I recommend adding them to both the BuildRequires > > *and* > > the Requires. > >

> > > > > > This would make it easier to just use the module to create an rpm > > > and > > > distribute it. > > > > > > Would a patch to do this be of interest?

> > > > Sure. > >

> > > > > > Best wishes, > > > Chris Travers > > >

> > > > Regards, > > > > -- Shlomi Fish > > > > > >

Tue Feb 18 09:18:38 2014 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'