Bug #93003 for Net-Download-Queue: Invalid $VERSION in Net::Download::Queue::Download*

Thu Feb 13 08:57:51 2014 dolmen [...] cpan.org - Ticket created

Subject:

Invalid $VERSION in Net::Download::Queue::Download*

Hi, Net::Download::Queue::Download and Net::Download::Queue::DownloadStatus have invalid $VERSION definition: our $VERSION = Net::Download::Queue::DBI::VERSION; The issues: - the $VERSION line is above "use strict;" which makes that you missed the report from strict.pm - the sigil is missing which means that the line is interpreted as: << our $VERSION = 'Net::Download::Queue::DBI::VERSION'; >> so the VERSION is obviously not what the author expected - 'Net::Download::Queue::DBI::VERSION' is not a valid version number This has caused indexing issues in the CPAN toolchain: https://github.com/andk/pause/issues/73#issuecomment-34863320 I think it would be better to completely remove the $VERSION. The package would be indexed with an 'undef' $VERSION and that would not be worse than the current situation. -- Olivier Mengué - http://perlresume.org/DOLMEN

Thu Feb 13 09:03:28 2014 dolmen [...] cpan.org - Correspondence added

Note that the CPAN toolchain (PAUSE, EUMM...) parse $VERSION in a different way than Perl itself and make the situation even less consistent. -- Olivier Mengué - http://perlresume.org/DOLMEN

Thu Feb 13 09:05:35 2014 dolmen [...] cpan.org - Correspondence added

Le 2014-02-13 15:03:28, DOLMEN a écrit : Show quoted text

> Note that the CPAN toolchain (PAUSE, EUMM...) parse $VERSION in a > different way than Perl itself and make the situation even less > consistent.

You can check with Parse::PMFile how PAUSE will parse the $VERSION: perl -MData::Dumper -MParse::PMFile -E 'say Dumper(Parse::PMFile->new->parse("lib/Net/Download/Queue/Download.pm"))' -- Olivier Mengué - http://perlresume.org/DOLMEN