Bug #92795 for Hailo: Fails with Test::Synopsis 0.7, 0.8, 0.9

Thu Feb 06 23:11:53 2014 ANDK [...] cpan.org - Ticket created

CC:	ZOFFIX [...] cpan.org
Subject:	Fails with Test::Synopsis 0.7, 0.8, 0.9

As per subject. Sample fail report: http://www.cpantesters.org/cpan/report/39333422 HTH && Regards, (Disclaimer: this was discovered by statistical analysis, I'm not speaking as a user)

Fri Feb 07 07:31:56 2014 cpan [...] zoffix.com - Correspondence added

Thanks for including me, Andreas. The fails were due to extract_synopsis() in Test::Synopsis was renamed to _extract_synopsis(), as it's an undocumented private sub. *** I've now reverted that change and released new version (v.10) to CPAN, and Hailo's test now works properly and passes *** To the author, I would recommend the following: 1) Move the synopsis test to xt/; it's an author test and should not be run for end users. 2) Use the documented all_synopsis_ok() or synopsis_ok() functions in your test. The limitation your current test tries to compensate for has been fixed. Plain, non-code text in the SYNOPSIS is no longer considered code. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Fri Feb 07 07:31:56 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Feb 07 08:04:44 2014 avar [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #92795] Fails with Test::Synopsis 0.7, 0.8, 0.9
Date:	Fri, 7 Feb 2014 14:04:15 +0100
To:	bug-Hailo [...] rt.cpan.org
From:	Ævar Arnfjörð Bjarmason <avar [...] cpan.org>

I'll fix this. There's a few bugs in Hailo I've been meaning to get to. Thanks. I actually think it makes sense for synopsis tests to be in t/ not xt/, because if the synopsis doesn't work for all users of the module (i.e. isn't smoked) I think that's a serious issue one would like to be informed about, as opposed to what usually goes in author tests, like spellchecking and things like that. On Fri, Feb 7, 2014 at 1:31 PM, Zoffix Znet via RT <bug-Hailo@rt.cpan.org> wrote: Show quoted text

> Queue: Hailo > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=92795 > > > Thanks for including me, Andreas. > > The fails were due to extract_synopsis() in Test::Synopsis was renamed to _extract_synopsis(), as it's an undocumented private sub. > > *** I've now reverted that change and released new version (v.10) to CPAN, and Hailo's test now works properly and passes *** > > To the author, I would recommend the following: > 1) Move the synopsis test to xt/; it's an author test and should not be run for end users. > 2) Use the documented all_synopsis_ok() or synopsis_ok() functions in your test. The limitation your current test tries to compensate for has been fixed. Plain, non-code text in the SYNOPSIS is no longer considered code. > > > -- > > Cheers, > ZZ [ https://metacpan.org/author/ZOFFIX ]

Tue Nov 27 07:51:11 2018 avar [...] cpan.org - Correspondence added

On 2014-02-07T08:04:44-05:00, AVAR wrote: Show quoted text

> I'll fix this. There's a few bugs in Hailo I've been meaning to get > to. Thanks. > > I actually think it makes sense for synopsis tests to be in t/ not > xt/, because if the synopsis doesn't work for all users of the module > (i.e. isn't smoked) I think that's a serious issue one would like to > be informed about, as opposed to what usually goes in author tests, > like spellchecking and things like that. > > On Fri, Feb 7, 2014 at 1:31 PM, Zoffix Znet via RT > <bug-Hailo@rt.cpan.org> wrote:

> > Queue: Hailo > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=92795 > > > > > Thanks for including me, Andreas. > > > > The fails were due to extract_synopsis() in Test::Synopsis was > > renamed to _extract_synopsis(), as it's an undocumented private sub. > > > > *** I've now reverted that change and released new version (v.10) to > > CPAN, and Hailo's test now works properly and passes *** > > > > To the author, I would recommend the following: > > 1) Move the synopsis test to xt/; it's an author test and should not > > be run for end users. > > 2) Use the documented all_synopsis_ok() or synopsis_ok() functions in > > your test. The limitation your current test tries to compensate for > > has been fixed. Plain, non-code text in the SYNOPSIS is no longer > > considered code. > > > > > > -- > > > > Cheers, > > ZZ [ https://metacpan.org/author/ZOFFIX ]

Fixed in the release I'm about to upload.

Tue Nov 27 07:51:12 2018 avar [...] cpan.org - Status changed from 'open' to 'resolved'