Bug #92738 for Imager: i_io_raw

Tue Feb 04 23:00:13 2014 TONYC [...] cpan.org - Ticket created

Subject:	i_io_raw_read mishandles COW scalars
Date:	Wed, 5 Feb 2014 14:59:57 +1100
To:	bug-Imager [...] rt.cpan.org
From:	tonyc [...] cpan.org

It needs to call SvPVbyte_force() instead of SvPVbyte(). Similarly for i_io_read()

Mon Mar 31 05:36:42 2014 TONYC [...] cpan.org - Correspondence added

On Tue Feb 04 23:00:13 2014, TONYC wrote: Show quoted text

> It needs to call SvPVbyte_force() instead of SvPVbyte(). > > Similarly for i_io_read()

I turned out that this statement was incorrect. The code didn't call SvPVbyte() in any case, and the code that was there did all that was necessary, if a little inefficiently. I've updated the code to be a bit more direct, based on what I learned writing the patch for [perl #116925] Tony

Mon Mar 31 05:37:00 2014 TONYC [...] cpan.org - Subject changed from 'i_io_raw_read mishandles COW scalars' to 'i_io_raw_read inefficient'

Mon Mar 31 05:37:21 2014 TONYC [...] cpan.org - Status changed from 'new' to 'patched'

Mon Aug 25 01:21:02 2014 TONYC [...] cpan.org - Correspondence added

On Mon Mar 31 05:36:42 2014, TONYC wrote: Show quoted text

> On Tue Feb 04 23:00:13 2014, TONYC wrote:

> > It needs to call SvPVbyte_force() instead of SvPVbyte(). > > > > Similarly for i_io_read()

> > > I turned out that this statement was incorrect. The code didn't call > SvPVbyte() in any case, and the code that was there did all that was > necessary, if a little inefficiently. > > I've updated the code to be a bit more direct, based on what I learned > writing the patch for [perl #116925]

This ended up breaking perl 5.6 and didn't add much efficiency, so the change was reverted. So rejecting. Tony

Mon Aug 25 01:21:03 2014 TONYC [...] cpan.org - Status changed from 'patched' to 'rejected'

Bug #92738 for Imager: i_io_raw_read inefficient