Skip Menu |

This queue is for tickets about the Cache CPAN distribution.

Report information
The Basics
Id: 92658
Status: resolved
Priority: 0/
Queue: Cache

People
Owner: Nobody in particular
Requestors: dom [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 2.08
Fixed in: (no value)



Subject: Use Digest::SHA instead of Digest::SHA1
Digest::SHA is a drop-in replacement for Digest::SHA1 provided by the perl core, so is preferred by Debian. Please consider applying the attached patch to switch Cache to Digest::SHA. Thanks! Dominic.
Subject: use-Digest-SHA.patch
From: Salvatore Bonaccorso <carnil@debian.org> Subject: use Digest::SHA instead of Digest::SHA1 Bug-Debian: http://bugs.debian.org/636648 diff --git a/Build.PL b/Build.PL index f6e98f6..47da9ba 100644 --- a/Build.PL +++ b/Build.PL @@ -16,7 +16,7 @@ my $builder = Test::Run::Builder->new( { 'DB_File' => '1.72', 'Date::Parse' => '2.24', - 'Digest::SHA1' => '2.01', + 'Digest::SHA' => 0, 'Fcntl' => '1.03', 'File::Find' => '0', 'File::NFSLock' => '1.20', diff --git a/META.json b/META.json index 07fee07..5dd8f73 100644 --- a/META.json +++ b/META.json @@ -35,7 +35,7 @@ "requires" : { "DB_File" : "1.72", "Date::Parse" : "2.24", - "Digest::SHA1" : "2.01", + "Digest::SHA" : "0", "Fcntl" : "1.03", "File::Find" : "0", "File::NFSLock" : "1.20", diff --git a/META.yml b/META.yml index 920f147..beefbc0 100644 --- a/META.yml +++ b/META.yml @@ -70,7 +70,7 @@ provides: requires: DB_File: 1.72 Date::Parse: 2.24 - Digest::SHA1: 2.01 + Digest::SHA: 0 Fcntl: 1.03 File::Find: 0 File::NFSLock: 1.20 diff --git a/lib/Cache/File.pm b/lib/Cache/File.pm index 6e0fab3..43462dc 100644 --- a/lib/Cache/File.pm +++ b/lib/Cache/File.pm @@ -25,7 +25,7 @@ use strict; use warnings; use Cache::File::Heap; use Cache::File::Entry; -use Digest::SHA1 qw(sha1_hex); +use Digest::SHA qw(sha1_hex); use Fcntl qw(LOCK_EX LOCK_NB); use Symbol (); use File::Spec;
Hi Dominic, On Sun Feb 02 11:18:19 2014, DOM wrote: Show quoted text
> Digest::SHA is a drop-in replacement for Digest::SHA1 provided by the > perl core, so is preferred by Debian. Please consider applying the > attached patch to switch Cache to Digest::SHA. >
thanks for the report. I applied a patch of my own in Cache-2.09. RESOLVEing as fixed. Regards, — Shlomi Fish Show quoted text
> Thanks! > Dominic.