Skip Menu |

This queue is for tickets about the Compress-Raw-Zlib CPAN distribution.

Report information
The Basics
Id: 92657
Status: resolved
Priority: 0/
Queue: Compress-Raw-Zlib

People
Owner: Nobody in particular
Requestors: BINGOS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 2.064
Fixed in: 2.065



Subject: [PATCH] resolve c++ build failure in core
I was integrating the latest Compress::Raw::* and IO-Compress updates into blead today and saw that Compress-Raw-Zlib failed to build when using c++ (g++ in this case). The attached patch which I cargo-culted together after looking at what was done for 2.056 resolves the issue. Many thanks.
Subject: zlibxs.diff
Did you forget to enclose the patch? Paul
On Sun Feb 02 14:30:34 2014, PMQS wrote: Show quoted text
> Did you forget to enclose the patch? > > Paul
Apparently I did :( Hopefully this will have an attached file.
Subject: zlibxs.diff
diff --git a/Zlib.xs b/Zlib.xs index 4b2573a..e1f2a1f 100644 --- a/Zlib.xs +++ b/Zlib.xs @@ -1450,7 +1450,7 @@ Perl_sv_dump(output); */ if (RETVAL == Z_NEED_DICT && s->dictionary) { STRLEN dlen; - const Bytef* b = SvPV(s->dictionary, dlen) ; + const Bytef* b = (Bytef*) SvPV(s->dictionary, dlen) ; s->dict_adler = s->stream.adler ; RETVAL = inflateSetDictionary(&(s->stream), b, dlen);
Thanks, applied. Paul