Bug #92596 for WWW-Google-CustomSearch: Patch to allow more google search parameters for WWW::Google::CustomSearch.pm

Thu Jan 30 19:45:15 2014 jacinta [...] ip-echelon.com - Ticket created

CC:	mohammad.anwar [...] yahoo.com
Subject:	Patch to allow more google search parameters for WWW::Google::CustomSearch.pm
Date:	Fri, 31 Jan 2014 11:44:57 +1100
To:	bug-WWW-Google-CustomSearch [...] rt.cpan.org
From:	Jacinta Richardson <jacinta [...] ip-echelon.com>

G’day Mohammad S Anwar, I’ve been looking at your WWW::Google::CustomSearch distribution, and it looks great. However it doesn’t quite allow me to specify all of the search parameters I want to. So I’ve modified it and attached the patch for you. I’ve also added to the documentation. I reordered some of your code (because it made things come out the way I wanted for comparison to an already established search string, but of course you can put it back in whatever order makes you happy. :) I do hope that you’re still maintaining this module and will accept this patch for a new release soon. Please let me know if I missed anything important. Thank you. Jacinta -- Jacinta Richardson Developer / Analyst IP-Echelon - Research, Intelligence, Education P +61 (3) 9111 5690 | E jacinta@ip-echelon.com | PGP 8EECAAA4 | W www.ip-echelon.com Australia: 480 Collins St, Melbourne, VIC 3000 +61 3 9111 5690 United States: 6715 Hollywood Blvd. Los Angeles, CA 90028 +1 (310) 606 2747 This communication may contain confidential or copyright information of IP-Echelon Pty Ltd. If you are not an intended recipient, you must not keep, forward, copy, use, save or rely on this communication, and any such action is unauthorised and prohibited. If you have received this communication in error, please notify privacy@ip-echelon.com, and then delete both it and your reply.

G’day Mohammad S Anwar,

I’ve been looking at your WWW::Google::CustomSearch distribution, and it looks great. However it doesn’t quite allow me to specify all of the search parameters I want to. So I’ve modified it and attached the patch for you. I’ve also added to the documentation. I reordered some of your code (because it made things come out the way I wanted for comparison to an already established search string, but of course you can put it back in whatever order makes you happy. :)

I do hope that you’re still maintaining this module and will accept this patch for a new release soon. Please let me know if I missed anything important.

Thank you.

Jacinta

Message body is not shown because sender requested not to inline it.

--

Jacinta Richardson

Developer / Analyst

IP-Echelon - Research, Intelligence, Education

P +61 (3) 9111 5690 | E jacinta@ip-echelon.com | PGP 8EECAAA4 | W www.ip-echelon.com

Australia: 480 Collins St, Melbourne, VIC 3000 +61 3 9111 5690

United States: 6715 Hollywood Blvd. Los Angeles, CA 90028 +1 (310) 606 2747

This communication may contain confidential or copyright information of IP-Echelon Pty Ltd. If you are not an intended recipient, you must not keep, forward, copy, use, save or rely on this communication, and any such action is unauthorised and prohibited. If you have received this communication in error, please notify privacy@ip-echelon.com, and then delete both it and your reply.

Download smime.p7s
application/pkcs7-signature 4.9k

Message body not shown because it is not plain text.

Fri Jan 31 18:42:31 2014 MANWAR [...] cpan.org - Taken

Fri Jan 31 18:42:32 2014 MANWAR [...] cpan.org - Requestor jacinta@ip-echelon.com deleted

Fri Jan 31 18:43:38 2014 MANWAR [...] cpan.org - Requestor jacinta@ip-echelon.com added

Fri Jan 31 18:43:39 2014 MANWAR [...] cpan.org - AdminCc mohammad.anwar@yahoo.com added

Sun Feb 02 13:59:43 2014 MANWAR [...] cpan.org - Starts changed from Not set to Thu Jan 30 19:00:00 2014

Sun Feb 02 13:59:43 2014 MANWAR [...] cpan.org - Status changed from 'new' to 'open'

Sun Feb 02 13:59:43 2014 MANWAR [...] cpan.org - Started changed from Sun Feb 02 13:59:43 2014 to Thu Jan 30 19:00:00 2014

Sun Feb 02 13:59:44 2014 MANWAR [...] cpan.org - Due changed from Not set to Sat Feb 01 19:00:00 2014

Sun Feb 02 14:00:51 2014 MANWAR [...] cpan.org - Broken in 0.09 added

Sun Feb 02 14:14:27 2014 MANWAR [...] cpan.org - Correspondence added

Hi Jacinta, I reviewed the patch you supplied. I like the idea of adding section "SYNOPSIS". I, therefore, added it to the pod document. However the code is unusable because of the use of $self->{cse_id} and $self->{api_key}. Also in your patch, you changed the API version as below: -Readonly my $API_VERSION => 'v1'; +Readonly my $API_VERSION => 'v1element'; If I am not mistaken then "v1element" is an invalid version, right? Regarding adding new search attributes you have mentioned in the patch, I went one step further and added everything in the updated API document provided by Google. The updated code (v 0.10) has been uploaded to CPAN and should be available publicly soon. Many Thanks. Best Regards, Mohammad S Anwar

Sun Feb 02 14:14:28 2014 MANWAR [...] cpan.org - Status changed from 'open' to 'patched'

Mon Feb 03 04:55:48 2014 MANWAR [...] cpan.org - Fixed in 0.10 added

Tue Feb 04 18:35:55 2014 jacinta [...] ip-echelon.com - Correspondence added

Subject:	Re: [rt.cpan.org #92596] Patch to allow more google search parameters for WWW::Google::CustomSearch.pm
Date:	Wed, 5 Feb 2014 10:35:44 +1100
To:	bug-WWW-Google-CustomSearch [...] rt.cpan.org
From:	Jacinta Richardson <jacinta [...] ip-echelon.com>

G'day Mohammad, Sorry about including $self->{} in the synopsis, I thought I'd cleaned that out from my code examples, but clearly one snuck in. It turns out that there is v1 and v1element, so technically it's not an invalid version, but is probably is invalid for what you're doing. It looks like I need some fairly significant modifications to these modules to actually get them to correctly parse the results from v1element queries, and I can't find the API documentation for all of these values anyway. :( I'm essentially trying to create a programmatic work around to generate the query that Google makes available via this: https://developers.google.com/custom-search/docs/js/cselement-devguide Can I suggest that you link to the API document provided by Google in your documentation, so people can refer to it for further information? Also, you've left in the warning that v1 is in labs, which seems unlikely now that Google has released v2. Thanks for the update. On Mon, Feb 3, 2014 at 6:14 AM, Mohammad Sajid Anwar via RT < bug-WWW-Google-CustomSearch@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=92596 > > > Hi Jacinta, > > I reviewed the patch you supplied. I like the idea of adding section > "SYNOPSIS". I, therefore, added it to the pod document. However the code is > unusable because of the use of $self->{cse_id} and $self->{api_key}. > > Also in your patch, you changed the API version as below: > -Readonly my $API_VERSION => 'v1'; > +Readonly my $API_VERSION => 'v1element'; > > If I am not mistaken then "v1element" is an invalid version, right? > > Regarding adding new search attributes you have mentioned in the patch, I > went one step further and added everything in the updated API document > provided by Google. > > The updated code (v 0.10) has been uploaded to CPAN and should be > available publicly soon. > > Many Thanks. > > Best Regards, > Mohammad S Anwar >

-- *Jacinta Richardson* *Developer / Analyst* *IP-Echelon - Research, Intelligence, Education* *P* +61 (3) 9111 5690 | *E* jacinta@ip-echelon.com | *PGP* 8EECAAA4<http://pgp.mit.edu/pks/lookup?op=get&search=0x5B0587008EECAAA4> | *W* www.ip-echelon.com Australia: 480 Collins St, Melbourne, VIC 3000 +61 3 9111 5690 United States: 6715 Hollywood Blvd. Los Angeles, CA 90028 +1 (310) 606 2747 This communication may contain confidential or copyright information of IP-Echelon Pty Ltd. If you are not an intended recipient, you must not keep, forward, copy, use, save or rely on this communication, and any such action is unauthorised and prohibited. If you have received this communication in error, please notify privacy@ip-echelon.com, and then delete both it and your reply.

Wed Feb 05 05:30:24 2014 MANWAR [...] cpan.org - Correspondence added

Hi Jacinta, It appears we are *NOT* on the same page. The link you referred to belongs to "Custom Search Element v2.0" whereas the CPAN module WWW::Google::CustomSearch refers to the "Custom Search JSON/Atom API v1.0". It is the name of the module that must have confused you. However it is clearly mentioned what it is for as in the module pod document as below: "WWW::Google::CustomSearch - Interface to Google JSON/Atom Custom Search." I will put the link the to the API document in the next update just in case for clarifications. I would love to create a perl interface for "Custom Search Element v2.0" but there is no clear documentation available (or at least I couldn't find). Please accept my apology for not be able to any help. Many Thanks. Best Regards, Mohammad S Anwar

Wed Feb 05 05:30:27 2014 MANWAR [...] cpan.org - Status changed from 'patched' to 'resolved'