Bug #92525 for future: ->export_to_level in Future::Utils

Mon Jan 27 22:02:32 2014 TEAM [...] cpan.org - Ticket created

Subject:

->export_to_level in Future::Utils

Currently Future::Utils is just importing the 'import' sub from Exporter - for some helper modules it's useful to apply imports to the caller, particularly for tidying up the 'use' list when similar patterns of modules are used in several places. Something along the lines of: use Some::Helper::Module qw(:all); try { fmap_void { pairmap { } ... } } catch { ... }; Inheriting from Exporter is my usual approach for this, alternatively would it be possible to add export_to_level to the import list? With the inheritance approach, there seems to be a bug with base.pm (https://github.com/doy/try-tiny/pull/11) which parent.pm doesn't have (https://github.com/doy/try-tiny/issues/14). cheers, Tom

Wed Feb 05 13:34:14 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Mon Jan 27 22:02:32 2014, TEAM wrote: Show quoted text

> Inheriting from Exporter is my usual approach for this, alternatively > would it be possible to add export_to_level to the import list?

I've occasionally run into odd issues by inheriting from Exporter; I prefer the explicit import approach. Does importing 'export_to_level' as well fix it? If so I'll go adding that to the import list. -- Paul Evans

Wed Feb 05 13:34:14 2014 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 25 12:57:48 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Wed Feb 05 13:34:14 2014, PEVANS wrote: Show quoted text

> Does importing 'export_to_level' as well fix it? If so I'll go adding > that to the import list.

Hmm. At first glance it would seem not: $ bzr di === modified file 'lib/Future/Utils.pm' --- lib/Future/Utils.pm 2014-02-22 03:50:03 +0000 +++ lib/Future/Utils.pm 2014-03-25 16:56:50 +0000 @@ -10,7 +10,7 @@ our $VERSION = '0.25'; -use Exporter 'import'; +use Exporter qw( import export_to_level ); our @EXPORT_OK = qw( call $ perl -Mblib -MFuture::Utils -E 'BEGIN { Future::Utils->export_to_level(0); } repeat { foo };' Can't locate object method "export_to_level" via package "Future::Utils" at -e line 1. BEGIN failed--compilation aborted at -e line 1. Odd that it still managed to import it though. -- Paul Evans

Tue Mar 25 13:22:05 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Tue Mar 25 12:57:48 2014, PEVANS wrote: Show quoted text

> On Wed Feb 05 13:34:14 2014, PEVANS wrote:

> > Does importing 'export_to_level' as well fix it? If so I'll go adding > > that to the import list.

> > Hmm. At first glance it would seem not:

Turns out that Exporter specialcases importing itself, and ignores any other symbol names. Also, manually importing &Exporter::export_to_level doesn't work as it fails due to inheritance: Can't locate object method "export" via package "Future::Utils" at /usr/share/perl/5.18/Exporter/Heavy.pm line 200. Turns out though that implementing export_to_level is a trivial wrapper around ->import. See attached patch -- Paul Evans

Subject:

rt92525.patch

=== modified file 'lib/Future/Utils.pm' --- lib/Future/Utils.pm 2014-02-22 03:50:03 +0000 +++ lib/Future/Utils.pm 2014-03-25 17:20:22 +0000 @@ -11,6 +11,11 @@ our $VERSION = '0.25'; use Exporter 'import'; +# Can't import the one from Exporter as it relies on package inheritance +sub export_to_level +{ + my $pkg = shift; local $Exporter::ExportLevel = 1 + shift; $pkg->import(@_); +} our @EXPORT_OK = qw( call

Tue Mar 25 13:22:06 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Mon Jun 02 08:02:50 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released in 0.26 -- Paul Evans

Mon Jun 02 08:02:51 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Mon Jun 02 08:02:52 2014 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.26 added