Skip Menu |

This queue is for tickets about the Text-CSV CPAN distribution.

Report information
The Basics
Id: 92509
Status: resolved
Priority: 0/
Queue: Text-CSV

People
Owner: Nobody in particular
Requestors: fulko.hew [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Text::CSV_PP incorrectly handles "0" fields under 'allow_whitespace=>1'
Date: Mon, 27 Jan 2014 12:31:48 -0500
To: bug-Text-CSV [...] rt.cpan.org
From: Fulko Hew <fulko.hew [...] gmail.com>
There is a difference in the XS version versus the PP version when you have the 'allow_whitespace' enabled. Under some conditions, a field containing "0" is greedily attached to the preceding field. Disabling the whitespace option (under PP version) _can_ correct the behavior However the XS version works correctly both with and without the whitespace option. Module allow_whitespace Go/nogo ====== ================ ======= CSV_PP 1 FAILS CSV_PP 0 ok CSV_XS 1 ok CSV_XS 0 ok A simple test case follows... #!/usr/bin/perl use Text::CSV_PP; use Data::Dumper; my $fh = *DATA; my $csv = Text::CSV_PP->new ( { allow_whitespace => 1 } ); # this fails #my $csv = Text::CSV_PP->new (); # this works $csv->column_names($csv->getline($fh)); my $hr = $csv->getline_hr($fh); print Dumper(\$hr); my $a = $hr->{name1}; my $b = $hr->{name3}; print "'$a', '$b'\n"; __DATA__ "name1","name2","name3" "value1","0","value3"
looks like this was patched in 1.33. Should this issue be closed?
Subject: Re: [rt.cpan.org #92509] Text::CSV_PP incorrectly handles "0" fields under 'allow_whitespace=>1'
Date: Sat, 30 May 2015 14:03:07 -0400
To: bug-Text-CSV [...] rt.cpan.org
From: Fulko Hew <fulko.hew [...] gmail.com>
If it was fixed, then it may be closed. Since that was some time ago, I have since lost the ability to verify it. On May 30, 2015 6:42 PM, "Breno G. de Oliveira via RT" < bug-Text-CSV@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=92509 > > > looks like this was patched in 1.33. Should this issue be closed? >
On Sun May 31 03:03:18 2015, fulko.hew@gmail.com wrote: Show quoted text
> If it was fixed, then it may be closed. Since that was some time ago, I > have since lost the ability to verify it. > On May 30, 2015 6:42 PM, "Breno G. de Oliveira via RT" < > bug-Text-CSV@rt.cpan.org> wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=92509 > > > > > looks like this was patched in 1.33. Should this issue be closed? > >
Closed as this has been fixed by https://github.com/makamaka/Text-CSV/commit/cf4a60d637660d717d88cc38af1beb3a39297d28 (as of 1.33)