Skip Menu |

This queue is for tickets about the Lingua-TreeTagger CPAN distribution.

Report information
The Basics
Id: 92345
Status: resolved
Priority: 0/
Queue: Lingua-TreeTagger

People
Owner: AXANTHOS [...] cpan.org
Requestors: cpan [...] zoffix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Moose enum Warnings
Hey, Attached patch fixes the warnings produced by the change to the way enum should be called. Below is a blurb the Moose guys have been distributing. ALSO, when I tried to build the package, I got "Lingua/TreeTagger/ConfigData.pm" not found and I don't see it on CPAN either; unsure whether that's something that "TreeTagger executable" (which I don't have) would provide or the distro is broken. --- We recently changed the syntax of enum declarations in Moose types. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
Subject: Lingua-TreeTagger-0.06.patch
diff -Naur Lingua-TreeTagger-0.06_orig/lib/Lingua/TreeTagger.pm Lingua-TreeTagger-0.06/lib/Lingua/TreeTagger.pm --- Lingua-TreeTagger-0.06_orig/lib/Lingua/TreeTagger.pm 2014-01-21 21:17:55.384532444 -0500 +++ Lingua-TreeTagger-0.06/lib/Lingua/TreeTagger.pm 2014-01-21 21:23:06.192536516 -0500 @@ -35,11 +35,11 @@ # purposes than part-of-speech tagging. Note that option '-quiet' is always # selected. -enum 'treetagger_option' => qw( +enum 'treetagger_option' => [qw( -token -lemma -sgml -ignore-prefix -no-unknown -cap-heuristics -hyphen-heuristics -pt-with-lemma -pt-with-prob -base -); +)]; #===============================================================================
Subject: Re: [rt.cpan.org #92345] [PATCH] Moose enum Warnings
Date: Thu, 23 Jan 2014 08:33:02 +0100
To: "bug-Lingua-TreeTagger [...] rt.cpan.org" <bug-Lingua-TreeTagger [...] rt.cpan.org>
From: Aris Xanthos <aris.xanthos [...] unil.ch>
Hi, Thanks a lot, I'll fix it as soon as possible! Best, Aris Show quoted text
> Le 22 janv. 2014 à 03:25, "Zoffix Znet via RT" <bug-Lingua-TreeTagger@rt.cpan.org> a écrit : > > Tue Jan 21 21:25:41 2014: Request 92345 was acted upon. > Transaction: Ticket created by ZOFFIX > Queue: Lingua-TreeTagger > Subject: [PATCH] Moose enum Warnings > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: cpan@zoffix.com > Status: open > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=92345 > > > > Hey, > > Attached patch fixes the warnings produced by the change to the way enum should be called. Below is a blurb the Moose guys have been distributing. ALSO, when I tried to build the package, I got "Lingua/TreeTagger/ConfigData.pm" not found and I don't see it on CPAN either; unsure whether that's something that "TreeTagger executable" (which I don't have) would provide or the distro is broken. > > --- > > We recently changed the syntax of enum declarations in Moose types. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org. > > -- > > Cheers, > ZZ [ https://metacpan.org/author/ZOFFIX ] > diff -Naur Lingua-TreeTagger-0.06_orig/lib/Lingua/TreeTagger.pm Lingua-TreeTagger-0.06/lib/Lingua/TreeTagger.pm --- Lingua-TreeTagger-0.06_orig/lib/Lingua/TreeTagger.pm 2014-01-21 21:17:55.384532444 -0500 +++ Lingua-TreeTagger-0.06/lib/Lingua/TreeTagger.pm 2014-01-21 21:23:06.192536516 -0500 @@ -35,11 +35,11 @@ # purposes than part-of-speech tagging. Note that option '-quiet' is always # selected. -enum 'treetagger_option' => qw( +enum 'treetagger_option' => [qw( -token -lemma -sgml -ignore-prefix -no-unknown -cap-heuristics -hyphen-heuristics -pt-with-lemma -pt-with-prob -base -); +)]; #===============================================================================
RT-Send-CC: aris.xanthos [...] unil.ch
Hi, Thanks a lot for your patch, I finally took the time to apply it. Hopefully everything should be fine in the new version (0.07) that I've just released to CPAN (and Github).