Skip Menu |

This queue is for tickets about the File-ReadBackwards CPAN distribution.

Report information
The Basics
Id: 92313
Status: open
Priority: 0/
Queue: File-ReadBackwards

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.05
Fixed in: (no value)



Subject: Tests run fail or run indefinitely unless terminated under HARNESS_OPTIONS=jN

If you look here: http://matrix.cpantesters.org/?dist=File-ReadBackwards%201.05;os=linux;reports=1

 

You will find a very large amount of failures reported by myself.

This is seemingly due to some kind of test interaction between the tests, due to tests running in parallel, via `export HARNESS_OPTIONS=j10`

Sometimes it just works ok and terminates with a failed test, other times, CPU goes 100% and I have to track down and kill t/bw.t

On Mon Jan 20 19:17:21 2014, KENTNL wrote: Show quoted text
> If you look here: > http://matrix.cpantesters.org/?dist=File- > ReadBackwards%201.05;os=linux;reports=1 > > You will find a very large amount of failures reported by myself. > > This is seemingly due to some kind of test interaction between the > tests, due > to tests running in parallel, via `export HARNESS_OPTIONS=j10` > > Sometimes it just works ok and terminates with a failed test, other > times, CPU > goes 100% and I have to track down and kill t/bw.t
I've attached a patch that should fix this.
Subject: 0001-use-unique-temp-files-in-tests.patch
From 1e7d32eb7534b5d6a13428dfa79268ec98c881bc Mon Sep 17 00:00:00 2001 From: Graham Knop <haarg@haarg.org> Date: Mon, 20 Jan 2014 22:31:13 -0500 Subject: [PATCH] use unique temp files in tests --- t/bw.t | 3 ++- t/large_file.t | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/t/bw.t b/t/bw.t index 07796bb..c5c39d5 100755 --- a/t/bw.t +++ b/t/bw.t @@ -5,10 +5,11 @@ use Test::More ; use Fcntl qw( :seek ) ; use File::ReadBackwards ; use Carp ; +use File::Temp qw( tempfile ); use vars qw( $opt_v ) ; -my $file = 'bw.data' ; +my (undef, $file) = tempfile('bw-XXXXXX', SUFFIX => '.data', TMPDIR => 1, CLEANUP => 1); my $is_crlf = ( $^O =~ /win32/i || $^O =~ /vms/i ) ; diff --git a/t/large_file.t b/t/large_file.t index 63d6b37..04abdaf 100755 --- a/t/large_file.t +++ b/t/large_file.t @@ -13,7 +13,7 @@ use File::ReadBackwards ; # NOTE: much of this code was taken from the core perl test script # ops/lfs.t. it was modified to test File::ReadBackwards and large files -my $test_file = 'bw.data' ; +my (undef, $test_file) = tempfile('bw-XXXXXX', SUFFIX => '.data', TMPDIR => 1, CLEANUP => 1); my @test_lines = ( "3rd from last line\n", -- 1.8.5.2
I can confirm, attached patch makes tests pass for me.