Bug #92290 for Devel-MAT: Unable to load dump back: Can't bless non-reference value

Fixed in attached patch. -- Paul Evans

=== modified file 'bin/pmat-show-sv' --- bin/pmat-show-sv 2014-01-15 17:27:58 +0000 +++ bin/pmat-show-sv 2014-01-21 00:13:05 +0000 @@ -64,6 +64,7 @@ my @pads = $sv->pads; foreach my $depth ( 0 .. $#pads ) { + next unless $pads[$depth]; say " pad[$depth]=" . $pads[$depth]->desc_addr; } === modified file 'lib/Devel/MAT/SV.pm' --- lib/Devel/MAT/SV.pm 2014-01-15 18:21:16 +0000 +++ lib/Devel/MAT/SV.pm 2014-01-21 00:13:05 +0000 @@ -1231,8 +1231,10 @@ bless $padnames, "Devel::MAT::SV::PADNAMES"; $padnames->_set_padcv_at( $self->addr ); - bless $_, "Devel::MAT::SV::PAD" for @pads; - $_->_set_padcv_at( $self->addr ) for @pads; + foreach my $pad ( @pads ) { + bless $pad, "Devel::MAT::SV::PAD"; + $pad->_set_padcv_at( $self->addr ); + } $self->{pads} = \@pads;

On Tue Jan 21 01:13:37 2014, PEVANS wrote: Show quoted text
This seems to be insufficient, I am still getting the error, patches applied... I am attaching the current dump I am playing with as well, perhaps something sufficiently different from the old one ~/devel/dbic/dbgit$ perl -MDevel::MAT\ 999 Devel::MAT version 999 required--this is only version 0.16. BEGIN failed--compilation aborted. ~/devel/dbic/dbgit$ sed -n '64,72p' $(which pmat-show-sv) say $sv->scope ? " scope=" . $sv->scope->desc_addr : " no scope"; say $sv->padlist ? " padlist=" . $sv->padlist->desc_addr : " no padlist"; say $sv->padnames ? " padnames=" . $sv->padnames->desc_addr : " no padnames"; my @pads = $sv->pads; foreach my $depth ( 0 .. $#pads ) { next unless $pads[$depth]; say " pad[$depth]=" . $pads[$depth]->desc_addr; } ~/devel/dbic/dbgit$ sed -n '1231,1242p' $(perldoc -l Devel::MAT::SV) bless $padnames, "Devel::MAT::SV::PADNAMES"; $padnames->_set_padcv_at( $self->addr ); foreach my $pad ( @pads ) { bless $pad, "Devel::MAT::SV::PAD"; $pad->_set_padcv_at( $self->addr ); } $self->{pads} = \@pads; # Under ithreads, constants are actually stored in the first padlist if( $df->ithreads ) { ~/devel/dbic/dbgit$ pmat-show-sv leaked_0xa6fbc50_pid10673.pmat 0xa6fbc50 Can't bless non-reference value at /home/rabbit/perl5/perlbrew/perls/5.18.1/lib/site_perl/5.18.1/x86_64-linux-thread-multi/Devel/MAT/SV.pm line 1235.

On Wed Jan 22 12:40:28 2014, RIBASUSHI wrote: Show quoted text
Huh. Oops. I managed to fix the bug, then remove half the bugfix from the code before committing it and building the .patch file... Find attached now the other half, though I'll also be CPAN'ing it momentarily. (this one can correctly load your attached dumpfile) -- Paul Evans

=== modified file 'lib/Devel/MAT/SV.pm' --- lib/Devel/MAT/SV.pm 2014-01-22 21:25:15 +0000 +++ lib/Devel/MAT/SV.pm 2014-01-22 21:39:51 +0000 @@ -1232,6 +1232,8 @@ $padnames->_set_padcv_at( $self->addr ); foreach my $pad ( @pads ) { + next unless $pad; + bless $pad, "Devel::MAT::SV::PAD"; $pad->_set_padcv_at( $self->addr ); } @@ -1252,7 +1254,7 @@ # Clear the obviously unused elements of lexnames and padlists foreach my $ix ( @$idxes ) { $padnames->_clear_elem( $ix ); - $_->_clear_elem( $ix ) for @pads; + $_ and $_->_clear_elem( $ix ) for @pads; } } }