It actually might be worse. From the dist dir after running Makefile.PL
(and make, and 'make install' just to be sure there was no older
version contaminating), I tried manually running just
ConstantLeadingUnderscore.t verbosely...
PERL_DL_NONLAZY=1 /usr/bin/arch -x86_64 perl5.12
"-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef
*Test::Harness::Switches; test_harness(1, 'blib/lib', 'blib/arch')"
t/ConstantLeadingUnderscore.t
t/ConstantLeadingUnderscore.t ..
1..75
ok 1 - VERSION variable
ok 2 - VERSION class method
ok 3 - VERSION class check 80
ok 4 - VERSION class check 1080
ok 5 - str: use constant
ok 6 - str: use constant 1.00
ok 7 - str: use constant;
ok 8 - str: use constant 1.00;
ok 9 - str: use constant 1.03
ok 10 - str: use constant 1.00 1.03
ok 11 - str: use constant 1.03;
ok 12 - str: use constant 1.00 1.03;
ok 13 - str: use constant 'FOO', 123
ok 14 - str: use constant 1.00 'FOO', 123
ok 15 - str: use constant 'FOO', 123;
ok 16 - str: use constant 1.00 'FOO', 123;
ok 17 - str: use constant "FOO", 123
ok 18 - str: use constant 1.00 "FOO", 123
ok 19 - str: use constant "FOO", 123;
ok 20 - str: use constant 1.00 "FOO", 123;
ok 21 - str: use constant q{FOO}, 123
ok 22 - str: use constant 1.00 q{FOO}, 123
ok 23 - str: use constant q{FOO}, 123;
ok 24 - str: use constant 1.00 q{FOO}, 123;
ok 25 - str: use constant qq{FOO}, 123
ok 26 - str: use constant 1.00 qq{FOO}, 123
ok 27 - str: use constant qq{FOO}, 123;
ok 28 - str: use constant 1.00 qq{FOO}, 123;
ok 29 - str: use constant FOO => 123
ok 30 - str: use constant 1.00 FOO => 123
ok 31 - str: use constant FOO => 123;
ok 32 - str: use constant 1.00 FOO => 123;
not ok 33 - str: use constant qw(FOO 123) # TODO qw() not handled yet
# Failed (TODO) test 'str: use constant qw(FOO 123)'
# at t/ConstantLeadingUnderscore.t line 84.
# got: undef
# expected: 'FOO'
not ok 34 - str: use constant 1.00 qw(FOO 123) # TODO qw() not handled yet
# Failed (TODO) test 'str: use constant 1.00 qw(FOO 123)'
# at t/ConstantLeadingUnderscore.t line 84.
# got: undef
# expected: 'FOO'
not ok 35 - str: use constant qw(FOO 123); # TODO qw() not handled yet
# Failed (TODO) test 'str: use constant qw(FOO 123);'
# at t/ConstantLeadingUnderscore.t line 84.
# got: undef
# expected: 'FOO'
not ok 36 - str: use constant 1.00 qw(FOO 123); # TODO qw() not handled yet
# Failed (TODO) test 'str: use constant 1.00 qw(FOO 123);'
# at t/ConstantLeadingUnderscore.t line 84.
# got: undef
# expected: 'FOO'
ok 37 - str: use constant {x=>1}
ok 38 - str: use constant 1.00 {x=>1}
ok 39 - str: use constant {x=>1};
ok 40 - str: use constant 1.00 {x=>1};
ok 41 - str: use constant { qw(x 1) }
ok 42 - str: use constant 1.00 { qw(x 1) }
ok 43 - str: use constant { qw(x 1) };
ok 44 - str: use constant 1.00 { qw(x 1) };
ok 45 - single policy Compatibility::ConstantLeadingUnderscore
ok 46 - VERSION object check 80
ok 47 - VERSION object check 1080
ok 48 - str: use constant FOO => 1;
ok 49 - str: use constant _FOO => 1;
ok 50 - str: use 5.005; use constant FOO => 1;
ok 51 - str: use 5.005; use constant _FOO => 1;
ok 52 - str: use 5.006; use constant _FOO => 1;
Invalid version format (non-numeric data) at
/sw/build.build/perl-critic-pulp-pm5124-80-1/Perl-Critic-Pulp-80/blib/lib/Perl/Critic/Policy/Compatibility/ConstantLeadingUnderscore.pm line
73.
# Looks like you planned 75 tests but ran 52.
# Looks like your test exited with 255 just after 52.
Dubious, test returned 255 (wstat 65280, 0xff00)
Failed 23/75 subtests
So the dubious sitaution around line 73 is just a visible diagnostic
even in quiet mode (and that may cause early giving up), compared to
even earlier real failures. For what it's worth, I have the latest
(CPAN) modules: constant-1.27 version-0.9907
dan
--
Daniel Macks
dmacks@netspace.org
