| CC: | zmughal [...] cpan.org |
| Subject: | html.t fails for two tests |
Hello,
When installing, I get the following errors:
===============================
t/00bootstrap.t .. ok
t/failure.t ...... ok
t/html.t ......... 1/2
# Failed test 'got register title'
# at t/html.t line 26.
t/html.t ......... 2/2
# Failed test 'got Twitter status'
# at t/html.t line 30.
# Looks like you failed 2 tests of 2.
t/html.t ......... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/2 subtests
Test Summary Report
-------------------
t/html.t (Wstat: 512 Tests: 2 Failed: 2)
Failed tests: 1-2
Non-zero exit status: 2
Files=3, Tests=4, 5 wallclock secs ( 0.02 usr 0.00 sys + 0.30 cusr 0.02 csys = 0.34 CPU)
Result: FAIL
===============================
The first one is because the Register page is now missing. The second is
because the Twitter HTML has changed slightly. The patch for that is:
--- lib/URI/Title/HTML.pm 2012-05-26 12:08:32.000000000 -0500
+++ lib/URI/Title/HTML.pm 2014-01-12 22:57:43.816152428 -0600
@@ -60,7 +60,7 @@
$title = "paste - ";
} elsif ($url =~ /twitter.com\/(.*?)\/status(es)?\/\d+/i) {
- $special_case = '<p class="js-tweet-text tweet-text ">([^\<]+)';
+ $special_case = '<p class="js-tweet-text tweet-text">([^\<]+)';
$title = "twitter - ";
} elsif ($url =~ /independent\.co\.uk/i) {