Bug #92084 for File-Sharedir-Install: option to remove installed share files that were removed from the dist

Sun Jan 12 12:48:07 2014 dmuey [...] cpan.org - Ticket created

Subject:

option to remove installed share files that were removed from the dist

It'd be nice to be able to cleanup the installed sharedir so that old files are removed. For example: v0.01 of our module installed …/foo …/bar …/baz v0.02 of our module has: an updated …/foo, the same …/bar, removes …/baz, and a new file …/wop When installing v0.02 on top of the old v0.01: ok: …/foo is updated ok: …/bar remains the same ok: …/wop is installed eek: …/baz still exists! It could be as simple as a bulk cleanup first (e.g. File::Path::Tiny::empty_dir($share_dir)). or a comparison of the installed dir against the dist dir to find what was removed in the dist dir and only remove those. Thanks!

Mon Jan 13 18:28:45 2014 ether [...] cpan.org - Requestor ETHER added

Thu Jan 16 13:18:28 2014 perl [...] pied.nu - Correspondence added

Thanks for the suggestion. This would definately be useful. I'll see if I can work on it soon. One thing is that auto-cleaning the installed directory is a bad idea. Those files might have been changed and those changes pertinent. I'm thinking of "delete-missing" option (remove everything not in the distro, changes are kept), "clean-first" (delete installed directory, all changes are lost) and "was-removed" (list of things to be deleted fron installed directory). It's been a while since I wrote this module so I'll have to remember the base assumptions.

Thu Jan 16 13:18:29 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 17 14:05:27 2014 perl [...] pied.nu - Correspondence added

I have uploaded version 0.07. It includes a delete_share() function which should do all that you need. Please tell me what you think.

Fri Jan 17 15:29:34 2014 dmuey [...] cpan.org - Correspondence added

On Fri Jan 17 14:05:27 2014, GWYN wrote: Show quoted text

> I have uploaded version 0.07. It includes a delete_share() function > which should do all that you need. > > Please tell me what you think.

cool, thanks! will check it out as soon as it shows up on whatever mirror I am hitting :)

Fri Jan 17 17:22:10 2014 dmuey [...] cpan.org - Correspondence added

On Fri Jan 17 15:29:34 2014, DMUEY wrote: Show quoted text

> On Fri Jan 17 14:05:27 2014, GWYN wrote:

> > I have uploaded version 0.07. It includes a delete_share() function > > which should do all that you need. > > > > Please tell me what you think.

> > cool, thanks! will check it out as soon as it shows up on whatever > mirror I am hitting :)

Looks like it will do the trickthanks! One question: The POD describes Maekfile.PL usage pretty clearly : delete_share '.'; # delete it all first install_share 'share'; # install the current version second but I’m not sure how it might be used w/ Module::Build (since hash order is arbitrary) my $builder = Module::Build->new( … delete_share => '.', install_share => 'share', … ); will that do the delete first then the install? thanks!

Sat Jan 18 01:33:57 2014 perl [...] pied.nu - Correspondence added

Show quoted text

> my $builder = Module::Build->new( > … > delete_share => '.', > install_share => 'share', > … > ); > > will that do the delete first then the install?

As you state, it will be random. I'd really like to say "not my problem." I dislike Module::Build. I dislike it more that it's causing this problem. That said, is it possible to call $builder->add( delete_share => '.'), then $builder->add( 'install_share' => 'share' ) and have it run in order?

Mon Jan 20 14:33:38 2014 perl [...] pied.nu - Correspondence added

You're going to have to help me. I don't see how you get from Module::Build to File::Sharedir::Install. I see Module::Build::Functions::install_share, but that doesn't use my code.

Mon Jan 20 15:02:03 2014 LEONT [...] cpan.org - Correspondence added

On Fri Jan 17 17:22:10 2014, DMUEY wrote: Show quoted text

> Looks like it will do the trickthanks! One question: > > The POD describes Maekfile.PL usage pretty clearly : > delete_share '.'; # delete it all first > install_share 'share'; # install the current version second > > but I’m not sure how it might be used w/ Module::Build (since hash > order is arbitrary) > > my $builder = Module::Build->new( > … > delete_share => '.', > install_share => 'share', > … > ); > > will that do the delete first then the install?

Module::Build doesn't use File::ShareDir::Install, but implements it on its own. So it will need its own implementation of delete_share too. Leon

Mon Jan 20 18:22:25 2014 ether [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #92084] option to remove installed share files that were removed from the dist
Date:	Mon, 20 Jan 2014 15:22:11 -0800
To:	Leon Timmermans via RT <bug-File-Sharedir-Install [...] rt.cpan.org>
From:	Karen Etheridge <ether [...] cpan.org>

On Mon, Jan 20, 2014 at 03:02:04PM -0500, Leon Timmermans via RT wrote: Show quoted text

> Module::Build doesn't use File::ShareDir::Install, but implements it on its own. So it will need its own implementation of delete_share too.

or possibly changed so it does use File::ShareDir::Install?

Tue Jan 21 14:26:17 2014 perl [...] pied.nu - Correspondence added

Le Lun 20 Jan 2014 18:22:25, ETHER a écrit : Show quoted text

> or possibly changed so it does use File::ShareDir::Install?

If/when that happens, we could create a syntax like : install_share => [ '-.', 'share' ] The - would be a delete, no minus would be install.

Sun Feb 09 12:45:31 2014 dmuey [...] cpan.org - Correspondence added

Sorry for the delay! Thank you again :) I misunderstood the relationship w/ Module::Build since it used the same name. I created rt 92863 for M::B. thank you again

Sun Feb 09 17:05:46 2014 LEONT [...] cpan.org - Correspondence added

On Fri Jan 17 14:05:27 2014, GWYN wrote: Show quoted text

> I have uploaded version 0.07. It includes a delete_share() function > which should do all that you need. > > Please tell me what you think.

I'm pretty sure that doesn't do the right thing. It deletes the staging area in blib/, not any installed files. As it stands now, it's pretty much a no-op. Leon

Sun Mar 02 07:10:34 2014 LEONT [...] cpan.org - Cc LEONT added

Wed May 13 14:48:01 2020 ether [...] cpan.org - Correspondence added

On 2014-02-09 14:05:46, LEONT wrote: Show quoted text

> I'm pretty sure that doesn't do the right thing. It deletes the > staging area in blib/, not any installed files. As it stands now, it's > pretty much a no-op.

I just ran into this after a new version of my distribution restructured the layout in its share/ directory. Clearly the test is not testing the install directory like it should :)