Bug #91893 for Win32-CommandLine: #define PERL_NO_GET

Mon Jan 06 05:04:19 2014 BULKDD [...] cpan.org - Ticket created

Subject:

#define PERL_NO_GET_CONTEXT

You need a ------------------------ #define PERL_NO_GET_CONTEXT ------------------------ before ------------------------ #include "EXTERN.h" ------------------------ at https://metacpan.org/source/RIVY/Win32-CommandLine-v0.7.318_12237505/lib/Win32/CommandLine.xs#L1 or else your dll will be very big in KB and slow. This can be improved. ------------------------ row = (AV *)sv_2mortal((SV *)newAV()); av_push(row, newSVpv( "cntUsage", 0 )); av_push(row, newSVpv( "DWORD", 0 )); av_push(row, newSVnv( offsetof(PROCESSENTRY32, cntUsage) )); av_push(row, newSVpv( "L!", 0 )); av_push(results, newRV((SV *)row)); ----------------------- don't mortal it, instead replace newRV with newRV_noinc. I didn't compile your module, just glanced over it.

Wed Jan 08 00:06:01 2014 RIVY [...] cpan.org - Severity Normal added

Wed Jan 08 00:06:01 2014 RIVY [...] cpan.org - Taken

Wed Jan 08 00:07:06 2014 RIVY [...] cpan.org - Ticket deleted

Wed Jan 08 00:07:08 2014 RIVY [...] cpan.org - Status changed from 'deleted' to 'open'

Wed Jan 08 00:11:22 2014 RIVY [...] cpan.org - Correspondence added

PERL_NO_GET_CONTEXT URLref: http://perldoc.perl.org/perlguts.html#How-multiple-interpreters-and-concurrency-are-supported newRV/newRV_inc vs newRV_noinc URLref: http://perldoc.perl.org/perlguts.html#Reference-Counts-and-Mortality

Sun Jan 12 15:03:58 2014 RIVY [...] cpan.org - Correspondence added

On Mon Jan 06 05:04:19 2014, BULKDD wrote: Show quoted text

> You need a > ------------------------ > #define PERL_NO_GET_CONTEXT > ------------------------ > before > ------------------------ > #include "EXTERN.h" > ------------------------ > > at https://metacpan.org/source/RIVY/Win32-CommandLine- > v0.7.318_12237505/lib/Win32/CommandLine.xs#L1 or else your dll will be > very big in KB and slow. > > This can be improved. > ------------------------ > row = (AV *)sv_2mortal((SV *)newAV()); > av_push(row, newSVpv( "cntUsage", 0 )); > av_push(row, newSVpv( "DWORD", 0 )); > av_push(row, newSVnv( offsetof(PROCESSENTRY32, cntUsage) )); > av_push(row, newSVpv( "L!", 0 )); > av_push(results, newRV((SV *)row)); > ----------------------- > don't mortal it, instead replace newRV with newRV_noinc. I didn't > compile your module, just glanced over it.

Thanks for the suggestions. I've tested and incorporated the suggested changes into v0.9+

Sun Jan 12 15:03:59 2014 RIVY [...] cpan.org - Status changed from 'open' to 'resolved'

Bug #91893 for Win32-CommandLine: #define PERL_NO_GET_CONTEXT