Bug #91857 for Test-Without-Module: Test::Without::Module->import leaks memory

Sat Jan 04 09:09:36 2014 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Ticket created

Subject:

Test::Without::Module->import leaks memory

‘use Foo’ is generally expected to be idempotent. In Test::Without::Module’s case, it keeps adding the same sub to @INC, creating a memory leak. Watch the memory usage go up: $ perl -MTest::Without::Module -e 'warn $$; while(1){ import Test::Without::Module }'

Wed Aug 20 10:38:09 2014 haarg [...] haarg.org - Correspondence added

Patch to fix attached.

Subject:

0001-only-add-INC-hook-once.patch

From ffdb95e2f98227872f7e96719a2f6f6743c90d5d Mon Sep 17 00:00:00 2001 From: Graham Knop <haarg@haarg.org> Date: Wed, 20 Aug 2014 10:37:51 -0400 Subject: [PATCH] only add @INC hook once --- lib/Test/Without/Module.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Test/Without/Module.pm b/lib/Test/Without/Module.pm index e3f240f..ed5de83 100755 --- a/lib/Test/Without/Module.pm +++ b/lib/Test/Without/Module.pm @@ -26,7 +26,7 @@ sub import { scrub( $module ); }; - unshift @INC, \&fake_module; + @INC = (\&fake_module, grep { !ref || $_ != \&fake_module } @INC); }; sub fake_module { -- 2.0.4

Wed Aug 20 10:38:10 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Aug 20 22:31:38 2014 rjbs [...] cpan.org - Correspondence added

Max, do you think you'll make a release of this? If you're not disposed to do it right now, I can take care of this and the other recent ticket. -- rjbs

Thu Aug 21 00:45:54 2014 webmaster [...] corion.net - Correspondence added

Subject:	Re: [rt.cpan.org #91857] Test::Without::Module->import leaks memory
Date:	Thu, 21 Aug 2014 07:45:02 +0300
To:	bug-Test-Without-Module [...] rt.cpan.org
From:	Max Maischein <webmaster [...] corion.net>

Hello Ricardo, I'm at YAPC::Europe right now, so I can't promise a release until I get back home. If this is urgent, ypu're welcome to do a release! -max On 21. August 2014 05:31:39 OESZ, Ricardo Signes via RT <bug-Test-Without-Module@rt.cpan.org> wrote: Show quoted text

> Queue: Test-Without-Module > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=91857 > > >Max, do you think you'll make a release of this? If you're not >disposed to do it right now, I can take care of this and the other >recent ticket. > >-- >rjbs

-- Diese Nachricht wurde von meinem Android-Mobiltelefon mit K-9 Mail gesendet.

Sat Aug 30 09:34:25 2014 corion [...] cpan.org - Correspondence added

Thanks for the report! Your fix is on its way to CPAN with 0.18.

Sat Aug 30 09:34:26 2014 corion [...] cpan.org - Status changed from 'open' to 'resolved'