Skip Menu |

This queue is for tickets about the CGI-Untaint-CountyStateProvince-GB CPAN distribution.

Report information
The Basics
Id: 91825
Status: resolved
Priority: 0/
Queue: CGI-Untaint-CountyStateProvince-GB

People
Owner: NHORNE [...] cpan.org
Requestors: dolmen [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Unimportant
Broken in: 0.11
Fixed in: 0.12



Subject: Do not bundle MYMETA.json
MYMETA.{yml,json} are files generated during the 'configure' phase of the build. They must not be bundled in the distribution. -- Olivier Mengué - http://perlresume.org/DOLMEN
Le 2018-06-28 17:12:09, NHORNE a écrit :
Show quoted text
> Would you please try https://github.com/nigelhorne/CGI-Untaint-
> CountyStateProvince-GB/commit/65de7b82de4a36dd4b09008a9ab871a283625bf4
> and let me know if this fixes it?

The real problem is that you should not have MANIFEST in the repo.
The strategy is not to whitelist files, but instead to blacklist the ones that should not be bundled in the distribution.
So you should have a MANIFEST.SKIP file that list files to be ignored, and let Makefile.PL build the MANIFEST automatically.
You can generate a basic MANIFEST.SKIP with `make maniskip`. Just add a line for `ignore.txt` and that's it.
By the way, do you really need ignore.txt?

-- 
Olivier Mengué - http://perlresume.org/DOLMEN
Nigels-MBP:CGI-Untaint-CountyStateProvince-GB njh$ make maniskip make: *** No rule to make target `maniskip'. Stop. Nigels-MBP:CGI-Untaint-CountyStateProvince-GB njh$