Skip Menu |

This queue is for tickets about the Archive-Tar-Stream CPAN distribution.

Report information
The Basics
Id: 91796
Status: resolved
Worked: 20 min
Priority: 0/
Queue: Archive-Tar-Stream

People
Owner: BRONG [...] cpan.org
Requestors: lkwg82 [...] gmx.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: missing typeflag in AddLink
Date: Thu, 02 Jan 2014 12:46:02 +0100
To: bug-Archive-Tar-Stream [...] rt.cpan.org
From: "Lars K.W. Gohlke" <lkwg82 [...] gmx.de>
Hallo Bron, I just use ur module and I'm very satisfied with it. Thx. I found a missing typeflag for links: currently: ----- code ----- sub AddLink { my $Self = shift; my $name = shift; my $linkname = shift; my $header = $Self->BlankHeader(@_); $header->{name} = $name; $header->{linkname} = $linkname; return $Self->WriteHeader($header); } -----/code ----- missing: $header->{typeflag} = 2; better: ----- code ----- sub AddLink { my $Self = shift; my $name = shift; my $linkname = shift; my $header = $Self->BlankHeader(@_); $header->{name} = $name; $header->{linkname} = $linkname; $header->{typeflag} = 2; return $Self->WriteHeader($header); } -----/code ----- maybe you can fix that or correct me! Thx a lot! ------------------------ Mit freundlichen Grüßen M.Sc. Dipl.-Inform. (FH) Lars K.W. Gohlke mailto:lkwg82@gmx.de ------------------------- Visit http://www.lgohlke.de 02.01.2014 12:39

Message body is not shown because sender requested not to inline it.

On Thu Jan 02 06:46:12 2014, lkwg82@gmx.de wrote: Show quoted text
> Hallo Bron, > > I just use ur module and I'm very satisfied with it. Thx. > > I found a missing typeflag for links: > > currently: > > ----- code ----- > sub AddLink { > my $Self = shift; > my $name = shift; > my $linkname = shift; > > my $header = $Self->BlankHeader(@_); > $header->{name} = $name; > $header->{linkname} = $linkname; > > return $Self->WriteHeader($header); > } > -----/code ----- > > missing: $header->{typeflag} = 2; > > better: > > ----- code ----- > sub AddLink { > my $Self = shift; > my $name = shift; > my $linkname = shift; > > my $header = $Self->BlankHeader(@_); > $header->{name} = $name; > $header->{linkname} = $linkname; > $header->{typeflag} = 2; > > return $Self->WriteHeader($header); > } > -----/code ----- > > maybe you can fix that or correct me!
You're absolutely right, as evidenced by the one location I'm using it! my $header = $Self->{tarstream}->AddLink($name, $target, typeflag => 2, mtime => $mtime);
Fixed in 0.02