| Subject: | [PATCH] perl v5.19.4-9-g0c0c317 breaks Acme::Pythonic |
This time I think Acme::Pythonic needs to change. calculator.t is relying on a longstanding perl bug. See https://rt.perl.org/Ticket/Display.html?id=3112 for details. See also the attached patch.
| Subject: | patch.txt |
diff -rup Acme-Pythonic-0.47-75TTjN-orig/t/calculator.t Acme-Pythonic-0.47-75TTjN/t/calculator.t
--- Acme-Pythonic-0.47-75TTjN-orig/t/calculator.t 2013-12-22 06:28:12.000000000 -0800
+++ Acme-Pythonic-0.47-75TTjN/t/calculator.t 2013-12-22 16:11:09.000000000 -0800
@@ -41,15 +41,15 @@ sub expr:
my $get = shift
my $left = term($get)
while:
- $left += term(1), last if $curr_tok eq PLUS
- $left -= term(1), last if $curr_tok eq MINUS
+ $left += term(1) if $curr_tok eq PLUS
+ $left -= term(1) if $curr_tok eq MINUS
return $left
sub term:
my $get = shift
my $left = prim($get)
while:
- $left *= prim(1), last if $curr_tok eq MUL
+ $left *= prim(1) if $curr_tok eq MUL
if $curr_tok eq DIV:
if my $d = prim(1):
$left *= $d**(-1) # Filter::Simple eated too much with conventional notation