Bug #91542 for Perl-Critic-Policy-logicLAB-ProhibitShellDispatch: System function in module

Fri Dec 20 13:04:06 2013 johantheolive [...] gmail.com - Ticket created

Subject:	System function in module
Date:	Fri, 20 Dec 2013 12:03:57 -0600
To:	bug-Perl-Critic-logicLAB [...] rt.cpan.org
From:	"johantheolive [...] gmail.com" <johantheolive [...] gmail.com>

I have the following code: $startSSH -> system( {async => 1} , "$setRemoteProfile $patCmd 1> /dev/null" ); where $startSSH is a Net::OpenSSH object. Perl::Critic::Policy::logicLAB::ProhibitShellDispatch erroneously identifies this as a system/exec statement.

Sat Dec 21 10:29:46 2013 jonasbn [...] cpan.org - Correspondence added

Subject:	Re: [rt.cpan.org #91542] System function in module
Date:	Sat, 21 Dec 2013 16:29:36 +0100
To:	bug-Perl-Critic-logicLAB [...] rt.cpan.org
From:	"Jonas B. Nielsen" <jonasbn [...] cpan.org>

Thanks for the bug report, I will look into it. jonasbn On Fri, Dec 20, 2013 at 7:04 PM, johantheolive@gmail.com via RT < bug-Perl-Critic-logicLAB@rt.cpan.org> wrote: Show quoted text

> Fri Dec 20 13:04:06 2013: Request 91542 was acted upon. > Transaction: Ticket created by johantheolive@gmail.com > Queue: Perl-Critic-logicLAB > Subject: System function in module > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: johantheolive@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=91542 > > > > I have the following code: > > $startSSH -> system( {async => 1} , "$setRemoteProfile $patCmd 1> > /dev/null" ); > > where $startSSH is a Net::OpenSSH > object. Perl::Critic::Policy::logicLAB::ProhibitShellDispatch erroneously > identifies this as a system/exec statement. > >

Sat Dec 21 10:29:46 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Dec 27 05:15:03 2013 jonasbn [...] cpan.org - Taken

Fri Dec 27 05:16:44 2013 jonasbn [...] cpan.org - Correspondence added

Hello, I have just uploaded release 0.03 to CPAN, please provide feedback if this release still bugs you and you code. I implemented a test case based on the example you provided and fixed accordingly. Thanks for the bug report, jonasbn

Fri Dec 27 09:31:27 2013 johantheolive [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #91542] System function in module
Date:	Fri, 27 Dec 2013 08:31:14 -0600
To:	bug-Perl-Critic-logicLAB [...] rt.cpan.org
From:	"johantheolive [...] gmail.com" <johantheolive [...] gmail.com>

Works great. Thanks for the quick fix! On Fri, Dec 27, 2013 at 4:16 AM, Jonas B. Nielsen via RT < bug-Perl-Critic-logicLAB@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=91542 > > > Hello, > > I have just uploaded release 0.03 to CPAN, please provide feedback if this > release still bugs you and you code. I implemented a test case based on the > example you provided and fixed accordingly. > > Thanks for the bug report, > > jonasbn >

Mon Jan 13 06:42:17 2014 jonasbn [...] cpan.org - Queue changed from Perl-Critic-logicLAB to Perl-Critic-Policy-logicLAB-ProhibitShellDispatch

Mon Jan 13 06:43:06 2014 jonasbn [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Jan 13 06:43:07 2014 jonasbn [...] cpan.org - Fixed in 0.03 added

Mon Jan 13 06:43:07 2014 jonasbn [...] cpan.org - Severity Important added

Mon Jan 13 06:43:07 2014 jonasbn [...] cpan.org - Broken in 0.01 added

Mon Jan 13 06:43:07 2014 jonasbn [...] cpan.org - Broken in 0.02 added

Bug #91542 for Perl-Critic-Policy-logicLAB-ProhibitShellDispatch: System function in module

Preferred bug tracker