Skip Menu |

This queue is for tickets about the Scalar-Does CPAN distribution.

Report information
The Basics
Id: 91497
Status: resolved
Priority: 0/
Queue: Scalar-Does

People
Owner: Nobody in particular
Requestors: jon [...] endpoint.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in:
  • 0.102
  • 0.200
  • 0.201
Fixed in: (no value)



Subject: t/iod-02filehandles.t fails if /tmp/myfifo already exists owned by another user
The test t/iod-02filehandles.t creates /tmp/myfifo but doesn't unlink it afterwards, so if multiple users running plenv or perlbrew build and test this package on their own, subsequent ones will fail because the test can't create a new /tmp/myfifo owned by the correct user. I would think that the fifo should be unlinked when the test is done, but also that the name should include a random component to avoid /tmp name collisions. If you'd like me to work up a patch, I'm game to. Thanks, Jon [Scalar-Does-0.201]$ make test PERL_DL_NONLAZY=1 /opt/alamerce/plenv/.plenv/versions/5.18.1/bin/perl5.18.1 "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/01basic.t ............ ok t/02does.t ............. ok t/03moosey.t ........... skipped: Test requires module 'MooseX::Types::Moose' but it's not found t/04cleanliness.t ...... ok t/05custom.t ........... ok t/06constants.t ........ ok t/07makerole.t ......... ok t/08mooselike.t ........ ok t/09warnings.t ......... ok t/10underscore.t ....... skipped: skipping lexical $_ test in Perl >= 5.17 t/11givenwhen.t ........ skipped: skipping given/when test in Perl >= 5.17 t/iod-01basic.t ........ ok t/iod-02filehandles.t .. mknod: `/tmp/myfifo': File exists t/iod-02filehandles.t: mknod failed at t/iod-02filehandles.t line 40. ^Cmake: *** [test_dynamic] Interrupt
Piers Cawley has submitted a patch for this: https://github.com/tobyink/p5-scalar-does/pull/1 I've released Scalar-Does-0.202 incorporating this patch: https://metacpan.org/release/TOBYINK/Scalar-Does-0.202 I believe this resolves this problem.
Very nice. Thanks!