Skip Menu |

This queue is for tickets about the version CPAN distribution.

Report information
The Basics
Id: 91478
Status: resolved
Priority: 0/
Queue: version

People
Owner: Nobody in particular
Requestors: khw [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)



Subject: PATCH: Need to move 'use locale' in 07locale.t
A test in the file is supposed to be testing what happens outside the scope of 'use locale'. Instead, it is in the scope. A patch is attached. A bug in the Perl core masked this test problem, which is marked critical because it is preventing me from delivering a fix for the core bug to blead.
Subject: 0018-07locale.t-use-locale-needs-to-be-moved.patch
From 02ebe615e1f76a9db8cd6c5ea14ba42bb4b8e9ef Mon Sep 17 00:00:00 2001 From: Karl Williamson <public@khwilliamson.com> Date: Tue, 17 Dec 2013 12:33:42 -0700 Subject: [PATCH 18/18] 07locale.t: 'use locale' needs to be moved A test that is supposed to be outside the scope of 'use locale' is instead within the scope. --- cpan/version/t/07locale.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cpan/version/t/07locale.t b/cpan/version/t/07locale.t index 76d60aa..7696de6 100644 --- a/cpan/version/t/07locale.t +++ b/cpan/version/t/07locale.t @@ -22,8 +22,6 @@ SKIP: { # test locale handling my $warning; - use locale; - local $SIG{__WARN__} = sub { $warning = $_[0] }; my $ver = 1.23; # has to be floating point number @@ -33,6 +31,8 @@ SKIP: { # because have to # evaluate in current # scope + use locale; + while (<DATA>) { chomp; $loc = setlocale( LC_ALL, $_); -- 1.8.1.3
Thanks, applied. Will be in the next CPAN release.