Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-CoderwallEndorse CPAN distribution.

Report information
The Basics
Id: 91409
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-CoderwallEndorse
People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Dec 13 19:55:20 2013 ether [...] cpan.org - Ticket created
Subject: Wrong phase being used to update files
The InstallTool phase is not the right phase to munge files in this plugin -- you should be using the FileMunger role instead. Having things use InstallTool unnecessarily makes it harder for other tools to find the right installer(s) being used for the dist, as well as for tools like Dist::Zilla::App::Command::dumpphases to accurately report what is being done in the dist.
  Sun Dec 15 22:35:54 2013 yanick+cpan [...] babyl.dyndns.org - Correspondence added
On Fri Dec 13 19:55:20 2013, ETHER wrote: Show quoted text
> The InstallTool phase is not the right phase to munge files in this > plugin -- you should be using the FileMunger role instead. Having > things use InstallTool unnecessarily makes it harder for other tools > to find the right installer(s) being used for the dist, as well as for > tools like Dist::Zilla::App::Command::dumpphases to accurately report > what is being done in the dist.
New release on its way to CPAN, moving the plugin's actions in the FileMunging phase. Btw, lotsa thanks for making me discover 'dumpphases'. That's something I wanted for the longest time! Joy, `/anick
  Sun Dec 15 22:35:54 2013 The RT System itself - Status changed from 'new' to 'open'
  Sun Dec 15 22:35:54 2013 yanick+cpan [...] babyl.dyndns.org - Status changed from 'open' to 'resolved'