Skip Menu |

This queue is for tickets about the ExtUtils-CChecker CPAN distribution.

Report information
The Basics
Id: 91363
Status: resolved
Priority: 0/
Queue: ExtUtils-CChecker

People
Owner: Nobody in particular
Requestors: PLICEASE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: 0.09



Subject: feature request: interface to turn quiet off
CChecker sets quiet => 1 in its constructor. It would be nice to have an interface to to set quiet => 0. I can hack this via: $cc->cbuilder->{quiet} = 0 but this breaks encapsulation. Thanks!
On Thu Dec 12 10:46:47 2013, PLICEASE wrote: Show quoted text
> CChecker sets quiet => 1 in its constructor. It would be nice to have > an interface to to set quiet => 0. I can hack this via:
Yeah, that sounds like a good idea. I can pop that in. -- Paul Evans
Patch attached. Uploaded to CPAN; will be 0.09. -- Paul Evans
Subject: rt91363.patch
=== modified file 'lib/ExtUtils/CChecker.pm' --- lib/ExtUtils/CChecker.pm 2013-12-12 17:07:21 +0000 +++ lib/ExtUtils/CChecker.pm 2013-12-12 17:07:51 +0000 @@ -75,6 +75,12 @@ the given name, instead of by adding extra C<-DI<SYMBOL>> arguments to the compiler flags. +=item quiet => BOOL + +If given, sets the C<quiet> option to the underlying C<ExtUtils::CBuilder> +instance. If absent, defaults to enabled. To disable quietness, i.e. to print +more verbosely, pass a defined-but-false value, such as C<0>. + =back =cut @@ -84,7 +90,10 @@ my $class = shift; my %args = @_; - my $cb = ExtUtils::CBuilder->new( quiet => 1 ); + my $quiet = 1; + $quiet = 0 if defined $args{quiet} and !$args{quiet}; + + my $cb = ExtUtils::CBuilder->new( quiet => $quiet ); return bless { cb => $cb,
On Thu Dec 12 12:36:02 2013, PEVANS wrote: Show quoted text
> Patch attached. > > Uploaded to CPAN; will be 0.09.
awesome, downloaded it and is working for me, kind thanks!