Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Net-ZooKeeper CPAN distribution.

Report information
The Basics
Id: 91216
Status: resolved
Priority: 0/
Queue: Net-ZooKeeper

People
Owner: MAF [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.35
Fixed in: 0.37



Subject: [PATCH] case insensitive regexp for error matching
t/10_invalid.t fails because the error message does not have the expected case: # Failed test 'set_acl(): invalid ACL array reference' # at t/10_invalid.t line 530. # 'Net::ZooKeeper::set_acl: acl_arr is not an ARRAY reference at t/10_invalid.t line 528. # ' # doesn't match '(?^:acl_arr is not an array reference)' # Failed test 'set_acl(): invalid ACL array reference to hash' # at t/10_invalid.t line 536. # 'Net::ZooKeeper::set_acl: acl_arr is not an ARRAY reference at t/10_invalid.t line 534. # ' # doesn't match '(?^:acl_arr is not an array reference)' # Looks like you failed 2 tests of 107. The attached patch fixes the problem. Regards, Slaven
Subject: 0001-case-insensitive-regexp-for-error-message-array-vs.-.patch
From 6a036c9e698db34f651afb111b38bd8b181c3bce Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven.rezic@idealo.de> Date: Fri, 6 Dec 2013 15:20:03 +0100 Subject: [PATCH] case insensitive regexp for error message (array vs. ARRAY) --- t/10_invalid.t | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/t/10_invalid.t b/t/10_invalid.t index 5e080b6..c1a118e 100644 --- a/t/10_invalid.t +++ b/t/10_invalid.t @@ -527,13 +527,13 @@ like($@, qr/Usage: Net::ZooKeeper::set_acl\(zkh, path, acl_arr, \.\.\.\)/, eval { $zkh->set_acl($node_path, 'foo'); }; -like($@, qr/acl_arr is not an array reference/, +like($@, qr/acl_arr is not an array reference/i, 'set_acl(): invalid ACL array reference'); eval { $zkh->set_acl($node_path, {}); }; -like($@, qr/acl_arr is not an array reference/, +like($@, qr/acl_arr is not an array reference/i, 'set_acl(): invalid ACL array reference to hash'); eval { -- 1.7.9.5
Patched in 0.37