Skip Menu |

This queue is for tickets about the WSDL-Compile CPAN distribution.

Report information
The Basics
Id: 91025
Status: open
Priority: 0/
Queue: WSDL-Compile

People
Owner: Nobody in particular
Requestors: upasna.shukla [...] gmail.com
cpan [...] zoffix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: New Moose may break your code
Date: Fri, 29 Nov 2013 03:43:18 +0530
To: bug-WSDL-Compile [...] rt.cpan.org
From: "Upasana Shukla" <upasna.shukla [...] gmail.com>
We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.
Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
Subject: WSDL-Compile-0.03.patch
diff -Naur WSDL-Compile-0.03_orig/Build.PL WSDL-Compile-0.03/Build.PL --- WSDL-Compile-0.03_orig/Build.PL 2014-01-25 12:32:42.764049663 -0500 +++ WSDL-Compile-0.03/Build.PL 2014-01-25 12:33:07.884174230 -0500 @@ -18,6 +18,7 @@ 'List::Util' => '1.21', 'Perl6::Junction' => '1.40000', 'XML::LibXML' => '1.69', + 'Class::Load' => 0.20, }, add_to_cleanup => ['WSDL-Compile-*'], create_makefile_pl => 'passthrough', diff -Naur WSDL-Compile-0.03_orig/lib/WSDL/Compile/Utils.pm WSDL-Compile-0.03/lib/WSDL/Compile/Utils.pm --- WSDL-Compile-0.03_orig/lib/WSDL/Compile/Utils.pm 2014-01-25 12:32:42.764049663 -0500 +++ WSDL-Compile-0.03/lib/WSDL/Compile/Utils.pm 2014-01-25 12:32:44.716059339 -0500 @@ -24,7 +24,7 @@ ); } -use Class::MOP; +use Class::Load; use Moose::Meta::Class; use MooseX::Params::Validate qw(pos_validated_list); use Perl6::Junction qw( any ); @@ -41,7 +41,7 @@ =cut sub wsdl_attributes { - my ( $meta ) = pos_validated_list( \@_, + my ( $meta ) = pos_validated_list( \@_, { isa => 'Moose::Meta::Class' }, ); @@ -61,15 +61,15 @@ =cut sub parse_attr { - my ( $attr ) = pos_validated_list( \@_, + my ( $attr ) = pos_validated_list( \@_, { isa => 'WSDL::Compile::Meta::Attribute::WSDL' }, ); my %data; - + my $associated_class = $attr->associated_class ? $attr->associated_class->name : 'unknown class'; - + $data{minOccurs} = $attr->xs_minOccurs; die $attr->name, " is required - xs_minOccurs cannot be set to 0" if $attr->is_required && $attr->xs_minOccurs == 0; @@ -82,7 +82,7 @@ if $data{minOccurs} > $data{maxOccurs}; } $data{name} = $attr->has_xsname ? $attr->xs_name : $attr->name; - + my $tc = $attr->type_constraint; my $tc_orig = $tc; if ($tc->parent->name eq 'Maybe') { @@ -110,7 +110,7 @@ if 'HashRef' eq any ( $tc->parent->name, $tc_orig->parent->name, - defined $tc->can('type_parameter') ? + defined $tc->can('type_parameter') ? ( $tc->type_parameter->parent->name, $tc->type_parameter->name, @@ -165,11 +165,11 @@ =cut sub load_class_for_meta { - my ( $class_name ) = pos_validated_list( \@_, + my ( $class_name ) = pos_validated_list( \@_, { isa => 'Str' }, ); - Class::MOP::load_class( $class_name ); + Class::Load::load_class( $class_name ); return Moose::Meta::Class->initialize( $class_name );
Would it be possible to get some movement on this issue? It is trivial to fix, and has been causing the tests to fail for a few years.