Skip Menu |

This queue is for tickets about the Test-Able-Runner CPAN distribution.

Report information
The Basics
Id: 90992
Status: patched
Priority: 0/
Queue: Test-Able-Runner

People
Owner: hanenkamp [...] cpan.org
Requestors: upasna.shukla [...] gmail.com
cpan [...] zoffix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: New Moose may break your code
Date: Fri, 29 Nov 2013 03:40:48 +0530
To: bug-Test-Able-Runner [...] rt.cpan.org
From: "Upasana Shukla" <upasna.shukla [...] gmail.com>
We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.
Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
Subject: Test-Able-Runner-1.001.patch
diff -Naur Test-Able-Runner-1.001_orig/dist.ini Test-Able-Runner-1.001/dist.ini --- Test-Able-Runner-1.001_orig/dist.ini 2014-01-25 10:57:25.927701400 -0500 +++ Test-Able-Runner-1.001/dist.ini 2014-01-25 10:58:51.104123765 -0500 @@ -9,4 +9,5 @@ [Prereq] Module::Pluggable = 3.6 Moose = 0.94 +Class::Load = 0.20 Test::Able = 0.09 diff -Naur Test-Able-Runner-1.001_orig/lib/Test/Able/Runner/Role/Meta/Class.pm Test-Able-Runner-1.001/lib/Test/Able/Runner/Role/Meta/Class.pm --- Test-Able-Runner-1.001_orig/lib/Test/Able/Runner/Role/Meta/Class.pm 2014-01-25 10:57:25.927701400 -0500 +++ Test-Able-Runner-1.001/lib/Test/Able/Runner/Role/Meta/Class.pm 2014-01-25 10:58:36.456051133 -0500 @@ -1,6 +1,7 @@ package Test::Able::Runner::Role::Meta::Class; our $VERSION = '1.001'; use Moose::Role; +use Class::Load; =head1 NAME @@ -68,8 +69,8 @@ # Use Module::Pluggable to find the test classes if ($meta->has_base_package) { my $base_package = $meta->base_package; - $meta->search_path( - new => (ref $base_package ? @$base_package : $base_package) + $meta->search_path( + new => (ref $base_package ? @$base_package : $base_package) ); return $meta->test_modules; } @@ -91,11 +92,11 @@ =item 1 -It retrieves a list of potential test classes using L</test_classes>. +It retrieves a list of potential test classes using L</test_classes>. =item 2 -It checks each package and throws away those with a package global variable named C<< $NOT_A_TEST >> that has been set to a true value. +It checks each package and throws away those with a package global variable named C<< $NOT_A_TEST >> that has been set to a true value. =item 3 @@ -119,7 +120,7 @@ PACKAGE: for my $test_class ($meta->name, $meta->test_classes) { # Attempt to load the classes - unless (Class::MOP::load_class($test_class)) { + unless (Class::Load::load_class($test_class)) { warn $@ if $@; warn "FAILED TO LOAD $test_class. Skipping."; next PACKAGE;
Patch applied and Test-Able-Runner 1.002 has been pushed to PAUSE for release. Thanks Upasana and Zoffix. On Sat Jan 25 11:00:47 2014, ZOFFIX wrote: Show quoted text
> Attached patch fixes the issue.