Bug #90968 for Catalyst-Plugin-Form-Processor: New Moose may break your code

Thu Nov 28 17:09:08 2013 upasna.shukla [...] gmail.com - Ticket created

Subject:	New Moose may break your code
Date:	Fri, 29 Nov 2013 03:38:57 +0530
To:	bug-Catalyst-Plugin-Form-Processor [...] rt.cpan.org
From:	"Upasana Shukla" <upasna.shukla [...] gmail.com>

We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.

Thu Nov 28 17:15:57 2013 ether [...] cpan.org - Reference by ticket #90657 added

Sat Jan 25 11:04:00 2014 cpan [...] zoffix.com - Correspondence added

Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

Catalyst-Plugin-Form-Processor-1.131420.patch

diff -Naur Catalyst-Plugin-Form-Processor-1.131420_orig/lib/Catalyst/Plugin/Form/Processor.pm Catalyst-Plugin-Form-Processor-1.131420/lib/Catalyst/Plugin/Form/Processor.pm --- Catalyst-Plugin-Form-Processor-1.131420_orig/lib/Catalyst/Plugin/Form/Processor.pm 2014-01-25 11:02:33.389226023 -0500 +++ Catalyst-Plugin-Form-Processor-1.131420/lib/Catalyst/Plugin/Form/Processor.pm 2014-01-25 11:02:55.053333444 -0500 @@ -3,7 +3,7 @@ $Catalyst::Plugin::Form::Processor::VERSION = '1.131420'; } use Moose::Role; -use Class::MOP; +use Class::Load; use HTML::FillInForm; use Module::Find; use Scalar::Util; @@ -33,7 +33,7 @@ $package .= '::' . ucfirst( $c->action->name ); } - Class::MOP::load_class( $package ); + Class::Load::load_class( $package ); # Single argument to Form::Processor->new means it's an item id or object. @@ -174,7 +174,7 @@ warn "Loading form module [$form]\n" if $debug; - Class::MOP::load_class( $form ); + Class::Load::load_class( $form ); eval { $form->load_form } || die "Failed load_module for form module [$form]: $@" if $@; diff -Naur Catalyst-Plugin-Form-Processor-1.131420_orig/Makefile.PL Catalyst-Plugin-Form-Processor-1.131420/Makefile.PL --- Catalyst-Plugin-Form-Processor-1.131420_orig/Makefile.PL 2014-01-25 11:02:33.389226023 -0500 +++ Catalyst-Plugin-Form-Processor-1.131420/Makefile.PL 2014-01-25 11:03:07.001392693 -0500 @@ -24,7 +24,7 @@ "LICENSE" => "perl", "NAME" => "Catalyst::Plugin::Form::Processor", "PREREQ_PM" => { - "Class::MOP" => 0, + "Class::Load" => "0.20", "HTML::FillInForm" => 0, "Module::Find" => 0, "Moose::Role" => 0, diff -Naur Catalyst-Plugin-Form-Processor-1.131420_orig/META.yml Catalyst-Plugin-Form-Processor-1.131420/META.yml --- Catalyst-Plugin-Form-Processor-1.131420_orig/META.yml 2014-01-25 11:02:33.389226023 -0500 +++ Catalyst-Plugin-Form-Processor-1.131420/META.yml 2014-01-25 11:03:16.985442202 -0500 @@ -16,7 +16,7 @@ version: 1.4 name: Catalyst-Plugin-Form-Processor requires: - Class::MOP: 0 + Class::Load: 0.20 HTML::FillInForm: 0 Module::Find: 0 Moose::Role: 0

Sat Jan 25 11:04:00 2014 The RT System itself - Status changed from 'new' to 'open'

Sat Jan 25 11:04:20 2014 cpan [...] zoffix.com - Requestor ZOFFIX added

Sun Jan 26 10:18:04 2014 mods [...] hank.org - Correspondence added

On Sat Jan 25 11:04:00 2014, ZOFFIX wrote: Show quoted text

> Attached patch fixes the issue.

Thanks for the patch. Will work on applying this week. Been putting this off. We have more usage in other modules that needs addressing: $ find . -name \*.pm | xargs fgrep Class::MOP::load_class | wc -l 147

Mon Jan 27 14:46:41 2014 mods [...] hank.org - Correspondence added

Uploaded to CPAN Catalyst-Plugin-Form-Processor-1.140270.tar.gz with patch. Thanks.

Mon Jan 27 14:46:42 2014 mods [...] hank.org - Status changed from 'open' to 'resolved'