Bug #90957 for App-PgCryobit: New Moose may break your code

Thu Nov 28 17:08:25 2013 upasna.shukla [...] gmail.com - Ticket created

Subject:	New Moose may break your code
Date:	Fri, 29 Nov 2013 03:38:10 +0530
To:	bug-App-PgCryobit [...] rt.cpan.org
From:	"Upasana Shukla" <upasna.shukla [...] gmail.com>

We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.

Thu Nov 28 17:15:54 2013 ether [...] cpan.org - Reference by ticket #90657 added

Thu Nov 28 17:43:03 2013 JETEVE [...] cpan.org - Correspondence added

Willfix

Thu Nov 28 17:43:03 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 24 22:09:05 2014 cpan [...] zoffix.com - Correspondence added

I see you got a repo for the other dist; does this one have one? If yes, you need to update the metaresources. In any case, unless you already fixed the issue, attached patch does so. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

App-PgCryobit-0.02.patch

diff -Naur App-PgCryobit-0.02_orig/lib/App/PgCryobit.pm App-PgCryobit-0.02/lib/App/PgCryobit.pm --- App-PgCryobit-0.02_orig/lib/App/PgCryobit.pm 2014-01-24 22:06:53.198589675 -0500 +++ App-PgCryobit-0.02/lib/App/PgCryobit.pm 2014-01-24 22:07:31.770590178 -0500 @@ -2,6 +2,7 @@ use Moose; use Config::General; +use Class::Load; use File::Temp; use DBI; @@ -59,11 +60,11 @@ my $factory_class = $self->configuration->{shipper}->{plugin}; my $load_err; - eval{ $shipper_factory = Class::MOP::load_class($factory_class) }; + eval{ $shipper_factory = Class::Load::load_class($factory_class) }; $load_err = $@; unless( $shipper_factory ){ $factory_class = 'App::PgCryobit::ShipperFactory::'.$factory_class; - eval{ $shipper_factory = Class::MOP::load_class($factory_class) }; + eval{ $shipper_factory = Class::Load::load_class($factory_class) }; $load_err = $@; } unless( $shipper_factory ){ diff -Naur App-PgCryobit-0.02_orig/Makefile.PL App-PgCryobit-0.02/Makefile.PL --- App-PgCryobit-0.02_orig/Makefile.PL 2014-01-24 22:06:53.198589675 -0500 +++ App-PgCryobit-0.02/Makefile.PL 2014-01-24 22:07:46.306590371 -0500 @@ -15,6 +15,7 @@ requires 'File::Basename' => 2.76; requires 'File::Temp'; requires 'Net::FTP' => 2.77; +requires 'Class::Load' => 0.20; ## This module is to be used only on a PostgreSQL fitted box requires_external_bin 'pg_ctlcluster';

Fri Jan 24 22:09:24 2014 cpan [...] zoffix.com - Requestor ZOFFIX added

Sat Jan 25 10:26:06 2014 JETEVE [...] cpan.org - Correspondence added

Applied patch. Will hit the world in version 0.03. Thanks! Jerome. On Fri Jan 24 22:09:05 2014, ZOFFIX wrote: Show quoted text

> I see you got a repo for the other dist; does this one have one? If > yes, you need to update the metaresources. > > In any case, unless you already fixed the issue, attached patch does > so.

Sat Jan 25 10:26:07 2014 JETEVE [...] cpan.org - Status changed from 'open' to 'patched'