Bug #90945 for Gitalist: New Moose may break your code

Thu Nov 28 17:07:28 2013 upasna.shukla [...] gmail.com - Ticket created

Subject:	New Moose may break your code
Date:	Fri, 29 Nov 2013 03:37:16 +0530
To:	bug-Gitalist [...] rt.cpan.org
From:	"Upasana Shukla" <upasna.shukla [...] gmail.com>

We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.

Thu Nov 28 17:15:51 2013 ether [...] cpan.org - Reference by ticket #90657 added

Fri Jan 24 18:33:50 2014 cpan [...] zoffix.com - Correspondence added

Attached is the patch that fixes this issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

Gitalist.patch

diff --git a/Makefile.PL b/Makefile.PL index c0555f5..50a97e9 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -85,6 +85,7 @@ requires 'MooseX::Types::Path::Class'; requires 'MooseX::Types::DateTime' => '0.05'; requires 'MooseX::Types::LoadableClass'; requires 'namespace::autoclean'; +requires 'Class::Load' => '0.20'; requires 'Git::PurePerl' => '0.47'; diff --git a/lib/Gitalist/Model/ContentMangler.pm b/lib/Gitalist/Model/ContentMangler.pm index 720e0b3..c461fba 100644 --- a/lib/Gitalist/Model/ContentMangler.pm +++ b/lib/Gitalist/Model/ContentMangler.pm @@ -3,6 +3,7 @@ use Moose; use MooseX::Types::Moose qw/HashRef/; use MooseX::Types::Common::String qw/NonEmptySimpleStr/; use Gitalist::ContentMangler::Resolver; +use Class::Load; use namespace::autoclean; extends 'Catalyst::Model'; @@ -27,7 +28,7 @@ has _resolver => ( default => sub { my $self = shift; my $class = $self->resolver_class; - Class::MOP::load_class($class); + Class::Load::load_class($class); return $class->new($self->resolver_config); }, ); @@ -56,7 +57,7 @@ sub process { return unless $transformer; - Class::MOP::load_class($transformer); + Class::Load::load_class($transformer); $transformer->new($config)->transform($c, $config); }

Fri Jan 24 18:33:50 2014 The RT System itself - Status changed from 'new' to 'open'

Fri Jan 24 18:34:11 2014 cpan [...] zoffix.com - Requestor ZOFFIX added

Fri Jan 24 19:02:51 2014 cpan [...] zoffix.com - Correspondence added

Oops. Looks like I didn't get all of them in the first patch. The attached is a second patch that fixes another instance. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

Gitalist--2.patch

diff --git a/lib/Gitalist/Git/CollectionOfRepositories/Vhost.pm b/lib/Gitalist/Git/CollectionOfRepositories/Vhost.pm index 345f21e..4748b75 100644 --- a/lib/Gitalist/Git/CollectionOfRepositories/Vhost.pm +++ b/lib/Gitalist/Git/CollectionOfRepositories/Vhost.pm @@ -1,4 +1,5 @@ use MooseX::Declare; +use Class::Load; class Gitalist::Git::CollectionOfRepositories::Vhost with Gitalist::Git::CollectionOfRepositoriesWithRequestState { @@ -11,7 +12,7 @@ class Gitalist::Git::CollectionOfRepositories::Vhost foreach my $name (keys %collections) { my %args = %{$collections{$name}}; my $class = delete $args{class}; - Class::MOP::load_class($class); + Class::Load::load_class($class); $collections{$name} = $class->new(%args); } my $ret = { %$args, collections => \%collections };

Sat Jan 25 09:14:38 2014 BROQ [...] cpan.org - Correspondence added

Thanks for the heads up, Upasana, and the fix, Zoffix! I've merged the patches and pushed up a new release, 0.004004, of Gitalist. -- Cheers, Dan Brook

Sat Jan 25 09:14:39 2014 BROQ [...] cpan.org - Status changed from 'open' to 'resolved'