Skip Menu |

This queue is for tickets about the Form-Sensible CPAN distribution.

Report information
The Basics
Id: 90917
Status: open
Priority: 0/
Queue: Form-Sensible

People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
upasna.shukla [...] gmail.com
cpan [...] zoffix.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: New Moose may break your code
Date: Fri, 29 Nov 2013 03:35:02 +0530
To: bug-Form-Sensible [...] rt.cpan.org
From: "Upasana Shukla" <upasna.shukla [...] gmail.com>
We recently deprecated Class::MOP::load_class in Moose. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.
Attached patch fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]
Subject: Form-Sensible-0.20023.patch
diff -Naur Form-Sensible-0.20023_orig/lib/Form/Sensible/Field.pm Form-Sensible-0.20023/lib/Form/Sensible/Field.pm --- Form-Sensible-0.20023_orig/lib/Form/Sensible/Field.pm 2014-01-24 20:27:22.850356795 -0500 +++ Form-Sensible-0.20023/lib/Form/Sensible/Field.pm 2014-01-24 20:28:08.050357387 -0500 @@ -4,7 +4,7 @@ use namespace::autoclean; use Carp; use Data::Dumper; -use Class::MOP; +use Class::Load; use Form::Sensible::DelegateConnection; @@ -264,7 +264,7 @@ } else { $class_to_load = 'Form::Sensible::Field::' . $fieldclass; } - Class::MOP::load_class($class_to_load); + Class::Load::load_class($class_to_load); # copy because we are going to remove class, as it wasn't there to begin with. my $config = { %{$fieldconfig} }; diff -Naur Form-Sensible-0.20023_orig/lib/Form/Sensible/Form.pm Form-Sensible-0.20023/lib/Form/Sensible/Form.pm --- Form-Sensible-0.20023_orig/lib/Form/Sensible/Form.pm 2014-01-24 20:27:22.850356795 -0500 +++ Form-Sensible-0.20023/lib/Form/Sensible/Form.pm 2014-01-24 20:28:24.450357602 -0500 @@ -6,7 +6,7 @@ use Form::Sensible::Validator; use Carp qw/croak/; use Data::Dumper; -use Class::MOP; ## I don't believe this is required +use Class::Load; ## I don't believe this is required ## a form is a collection of fields. Different form types will work differently. @@ -267,7 +267,7 @@ } else { $classname = 'Form::Sensible::Validator::' . $classname; } - Class::MOP::load_class($classname); + Class::Load::load_class($classname); $validator = $classname->new(@{$self->validator_args}); return $validator; diff -Naur Form-Sensible-0.20023_orig/lib/Form/Sensible.pm Form-Sensible-0.20023/lib/Form/Sensible.pm --- Form-Sensible-0.20023_orig/lib/Form/Sensible.pm 2014-01-24 20:27:22.850356795 -0500 +++ Form-Sensible-0.20023/lib/Form/Sensible.pm 2014-01-24 20:28:43.522357852 -0500 @@ -2,7 +2,7 @@ use Moose; use namespace::autoclean; -use Class::MOP; +use Class::Load; use Form::Sensible::Form; use Form::Sensible::Field; use Form::Sensible::Field::DateTime; @@ -81,7 +81,7 @@ } else { $class_to_load = 'Form::Sensible::Renderer::' . $type; } - Class::MOP::load_class($class_to_load); + Class::Load::load_class($class_to_load); if (!$options) { $options = {}; } @@ -101,7 +101,7 @@ } else { $class_to_load = 'Form::Sensible::Validator::' . $type; } - Class::MOP::load_class($class_to_load); + Class::Load::load_class($class_to_load); return $class_to_load->new($options); } diff -Naur Form-Sensible-0.20023_orig/Makefile.PL Form-Sensible-0.20023/Makefile.PL --- Form-Sensible-0.20023_orig/Makefile.PL 2014-01-24 20:27:22.846356795 -0500 +++ Form-Sensible-0.20023/Makefile.PL 2014-01-24 20:29:08.298358177 -0500 @@ -7,7 +7,7 @@ # Specific dependencies requires 'Moose'; requires 'namespace::autoclean'; -requires 'Class::MOP'; +requires 'Class::Load' => '0.20'; requires 'DateTime'; requires 'DateTime::Set'; requires 'DateTime::Format::Natural'; diff -Naur Form-Sensible-0.20023_orig/META.yml Form-Sensible-0.20023/META.yml --- Form-Sensible-0.20023_orig/META.yml 2014-01-24 20:27:22.850356795 -0500 +++ Form-Sensible-0.20023/META.yml 2014-01-24 20:28:59.018358055 -0500 @@ -23,7 +23,7 @@ - t requires: Carp: 0 - Class::MOP: 0 + Class::Load: 0 Data::Dumper: 0 DateTime: 0 DateTime::Format::Natural: 0