Skip Menu |

This queue is for tickets about the jQuery-File-Upload CPAN distribution.

Report information
The Basics
Id: 90861
Status: open
Worked: 1 min
Priority: 0/
Queue: jQuery-File-Upload
People
Owner: Nobody in particular
Requestors: RSAVAGE [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.20
Fixed in: 0.20

History Show all quoted text
  Wed Nov 27 17:47:05 2013 RSAVAGE [...] cpan.org - Ticket created
Subject: POD error stops install
# Testing jQuery::File::Upload 0.20, Perl 5.014002, /home/ron/perl5/perlbrew/perls/perl-5.14.2/bin/perl t/00-load.t ....... All 1 subtests passed t/manifest.t ...... skipped: Author tests not required for installation t/pod-coverage.t .. All 1 subtests passed # Failed test 'POD test for blib/lib/jQuery/File/Upload.pm' # at /home/ron/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Pod.pm line 186. # blib/lib/jQuery/File/Upload.pm (2325): alternative text 'pre/post request' contains non-escaped | or / # Looks like you failed 1 test of 1. t/pod.t ........... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/1 subtests Test Summary Report ------------------- t/00-load.t (Wstat: 11 Tests: 1 Failed: 0) Non-zero wait status: 11 t/pod-coverage.t (Wstat: 11 Tests: 1 Failed: 0) Non-zero wait status: 11 t/pod.t (Wstat: 256 Tests: 1 Failed: 1) Failed test: 1 Non-zero exit status: 1 Files=4, Tests=3, 0 wallclock secs ( 0.02 usr 0.01 sys + 0.26 cusr 0.04 csys = 0.33 CPU) Result: FAIL Failed 3/4 test programs. 1/3 subtests failed.
  Wed Nov 27 19:54:59 2013 RSAVAGE [...] cpan.org - Correspondence added 1 min
I should add I fixed /all/ the POD links in my fork, so suggest you just copy all the text into your version ;-).
  Wed Nov 27 19:54:59 2013 RSAVAGE [...] cpan.org - Fixed in 0.20 added
  Thu Nov 28 11:50:30 2013 ether [...] cpan.org - Correspondence added
Pod tests should not run at install time - they should only run for the author. Please add guards around your tests to skip_all unless $ENV{AUTHOR_TESTING}, or move them to the xt/ directory.
  Thu Nov 28 11:50:30 2013 The RT System itself - Status changed from 'new' to 'open'
  Thu Nov 28 16:45:11 2013 ron [...] savage.net.au - Correspondence added
Subject: Re: [rt.cpan.org #90861] POD error stops install
Date: Fri, 29 Nov 2013 08:44:50 +1100
To: bug-jQuery-File-Upload [...] rt.cpan.org
From: Ron Savage <ron [...] savage.net.au>
Hi Karen On 29/11/13 03:50, Karen Etheridge via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=90861 > > > Pod tests should not run at install time - they should only run for the author. Please add guards around your tests to skip_all unless $ENV{AUTHOR_TESTING}, or move them to the xt/ directory.
For the record, I didn't write jQuery::File::Upload (which uses Image::Magick), but I did write jQuery::File::Upload::Imager (which obviously uses Imager). Also for the record :-) I don't support the idea of only running POD tests in those circumstances. I much prefer to know they run successfully on the users machine. And, I have started using guards, as in: use Test::More; eval "use Test::Pod 1.45"; plan skip_all => "Test::Pod 1.45 required for testing POD" if $@; all_pod_files_ok(); Also, as I release new versions/modules I am, for my own modules, moving the tests to xt/. Cheers -- Ron Savage http://savage.net.au/