Bug #90803 for Crypt-SSLeay: 8th test in 01-connect.t fails for version 0.64

Mon Nov 25 11:32:23 2013 mkmetw [...] hotmail.com - Ticket created

Subject:	8th test in 01-connect.t fails for version 0.64
Date:	Mon, 25 Nov 2013 16:32:03 +0000
To:	"bug-Crypt-SSLeay [...] rt.cpan.org" <bug-crypt-ssleay [...] rt.cpan.org>
From:	Manoj Kumar <mkmetw [...] hotmail.com>

Hi, I am trying to install Crypt::SSLeay on my Win XP 32-bit machine and the following test is failing - # Failed test 'socket is now non-blocking' # at t/01-connect.t line 64. # got: '' # expected: '0' # Looks like you failed 1 test of 8. t/01-connect.t .. This failure is because of the following lines in subroutine blocking in IO::Socket version 1.32 - my $orig= !${*$sock}{io_sock_nonblocking}; return $orig unless @_; In the above code, if io_sock_nonblocking is non-zero, $orig will be empty string. So, I have modified the test as follows (output of diff -u) - --- t/01-connect.orig.t 2012-07-30 14:35:34.000000000 +0200 +++ t/01-connect.t 2013-11-25 17:16:52.861250000 +0100 @@ -61,5 +61,5 @@ is( $sock->blocking, 1, 'socket is blocking' ); $sock->blocking(0); - is( $sock->blocking, 0, 'socket is now non-blocking' ); + is( $sock->blocking, $^O eq 'MSWin32' ? '' : 0, 'socket is now non-blocking' ); } Regards,

Wed Apr 02 13:39:56 2014 nanis [...] runu.moc.invalid - Correspondence added

Hello Manoj: The correct fix is to test for true/false rather than integer values. This has been patched in the development version, and will be included in the next test release. See https://github.com/nanis/Crypt-SSLeay/commit/3ee71148abf4ebe3edb766128c6288881ca4fbfe Thank you for your input, -- Sinan On Mon Nov 25 11:32:23 2013, mkmetw@hotmail.com wrote: Show quoted text

> Hi, > > I am trying to install Crypt::SSLeay on my Win XP 32-bit machine and > the following test is failing - > > # Failed test 'socket is now non-blocking' > # at t/01-connect.t line 64. > # got: '' > # expected: '0' > # Looks like you failed 1 test of 8. > t/01-connect.t .. > > This failure is because of the following lines in subroutine blocking > in IO::Socket version 1.32 - > > my $orig= !${*$sock}{io_sock_nonblocking}; > > return $orig unless @_; > > In the above code, if io_sock_nonblocking is non-zero, $orig will be > empty string. > > So, I have modified the test as follows (output of diff -u) - > > --- t/01-connect.orig.t 2012-07-30 14:35:34.000000000 +0200 > +++ t/01-connect.t 2013-11-25 17:16:52.861250000 +0100 > @@ -61,5 +61,5 @@ > > is( $sock->blocking, 1, 'socket is blocking' ); > $sock->blocking(0); > - is( $sock->blocking, 0, 'socket is now non-blocking' ); > + is( $sock->blocking, $^O eq 'MSWin32' ? '' : 0, 'socket is now > non-blocking' ); > } > > Regards, > >

Wed Apr 02 13:39:56 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Apr 02 13:39:57 2014 nanis [...] runu.moc.invalid - Status changed from 'open' to 'patched'

Wed Apr 02 13:39:57 2014 nanis [...] runu.moc.invalid - Taken

Thu Apr 24 19:30:22 2014 nanis [...] runu.moc.invalid - Status changed from 'patched' to 'resolved'

Thu Apr 24 19:30:23 2014 nanis [...] runu.moc.invalid - Fixed in 0.72 added