Bug #90690 for Frost: New Moose may break your code

Fri Nov 22 21:30:29 2013 upasna.shukla [...] gmail.com - Ticket created

Subject:	New Moose may break your code
Date:	Sat, 23 Nov 2013 08:00:17 +0530
To:	bug-Frost [...] rt.cpan.org
From:	"Upasana Shukla" <upasna.shukla [...] gmail.com>

We recently changed the syntax of enum declarations in Moose types. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.

Sat Nov 23 12:07:51 2013 ether [...] cpan.org - Reference by ticket #90657 added

Tue Jan 21 19:00:38 2014 cpan [...] zoffix.com - Correspondence added

Attached patch fixes the enum warnings, but the tests still fail, as per RT#67547 -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

Frost-moose-enum-warnings.patch

diff -Naur Frost-0.70_orig/lib/Frost/Types.pm Frost-0.70/lib/Frost/Types.pm --- Frost-0.70_orig/lib/Frost/Types.pm 2014-01-21 18:54:20.900419575 -0500 +++ Frost-0.70/lib/Frost/Types.pm 2014-01-21 18:54:58.712420070 -0500 @@ -10,8 +10,8 @@ our $VERSION = 0.64; our $AUTHORITY = 'cpan:ERNESTO'; -enum 'Frost::SortType', ( SORT_INT, SORT_FLOAT, SORT_DATE, SORT_TEXT, ); -enum 'Frost::Status', ( STATUS_NOT_INITIALIZED, STATUS_MISSING, STATUS_LOADED, STATUS_EXISTS, ); +enum 'Frost::SortType', [ SORT_INT, SORT_FLOAT, SORT_DATE, SORT_TEXT, ]; +enum 'Frost::Status', [ STATUS_NOT_INITIALIZED, STATUS_MISSING, STATUS_LOADED, STATUS_EXISTS, ]; subtype 'Frost::Date' => as 'Str' diff -Naur Frost-0.70_orig/t/000_moose_examples/002_example_Moose_POOP.t Frost-0.70/t/000_moose_examples/002_example_Moose_POOP.t --- Frost-0.70_orig/t/000_moose_examples/002_example_Moose_POOP.t 2014-01-21 18:54:20.900419575 -0500 +++ Frost-0.70/t/000_moose_examples/002_example_Moose_POOP.t 2014-01-21 18:55:27.936420453 -0500 @@ -72,7 +72,7 @@ # ########################################### - enum 'State' => qw(draft posted pending archive); + enum 'State' => [qw(draft posted pending archive)]; has 'headline' => (is => 'rw', isa => 'Headline'); has 'summary' => (is => 'rw', isa => 'Summary');

Tue Jan 21 19:00:38 2014 The RT System itself - Status changed from 'new' to 'open'