Bug #90681 for Finance-Bank-SentinelBenefits-Csv401kConverter: New Moose may break your code

Fri Nov 22 21:29:38 2013 upasna.shukla [...] gmail.com - Ticket created

Subject:	New Moose may break your code
Date:	Sat, 23 Nov 2013 07:59:27 +0530
To:	bug-Finance-Bank-SentinelBenefits-Csv401kConverter [...] rt.cpan.org
From:	"Upasana Shukla" <upasna.shukla [...] gmail.com>

We recently changed the syntax of enum declarations in Moose types. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.

Sat Nov 23 12:07:49 2013 ether [...] cpan.org - Reference by ticket #90657 added

Tue Jan 21 18:51:47 2014 cpan [...] zoffix.com - Correspondence added

Attached is the patch that fixes the issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

Finance-Bank-Moose-enum-warnings.patch

diff -Naur Finance-Bank-SentinelBenefits-Csv401kConverter-0.5_orig/lib/Finance/Bank/SentinelBenefits/Csv401kConverter/Types.pm Finance-Bank-SentinelBenefits-Csv401kConverter-0.5/lib/Finance/Bank/SentinelBenefits/Csv401kConverter/Types.pm --- Finance-Bank-SentinelBenefits-Csv401kConverter-0.5_orig/lib/Finance/Bank/SentinelBenefits/Csv401kConverter/Types.pm 2014-01-21 18:48:54.868415303 -0500 +++ Finance-Bank-SentinelBenefits-Csv401kConverter-0.5/lib/Finance/Bank/SentinelBenefits/Csv401kConverter/Types.pm 2014-01-21 18:49:21.196415648 -0500 @@ -6,8 +6,8 @@ use Moose::Util::TypeConstraints; -enum 'ContributionSource' => qw(Deferral Match); -enum 'TradeSide' => qw(Buy Sell ShtSell); +enum 'ContributionSource' => [qw(Deferral Match)]; +enum 'TradeSide' => [qw(Buy Sell ShtSell)]; no Moose::Util::TypeConstraints;

Tue Jan 21 18:51:48 2014 The RT System itself - Status changed from 'new' to 'open'

Wed Mar 19 11:02:06 2014 DSOLIMANO [...] cpan.org - Taken

Wed Mar 19 11:02:56 2014 DSOLIMANO [...] cpan.org - Correspondence added

Thanks, I shall implement this patch. I also have some other work queued up for the 1.0 release.

Tue May 20 09:03:15 2014 DSOLIMANO [...] cpan.org - Broken in 0.5 added

Wed May 21 09:48:22 2014 DSOLIMANO [...] cpan.org - Status changed from 'open' to 'resolved'

Wed May 21 09:48:22 2014 DSOLIMANO [...] cpan.org - Fixed in 1.0 added