Bug #90664 for helm: New Moose may break your code

Fri Nov 22 21:28:03 2013 upasna.shukla [...] gmail.com - Ticket created

Subject:	New Moose may break your code
Date:	Sat, 23 Nov 2013 07:57:49 +0530
To:	bug-helm [...] rt.cpan.org
From:	"Upasana Shukla" <upasna.shukla [...] gmail.com>

We recently changed the syntax of enum declarations in Moose types. It appears that your module is affected. You can read more about the change here: https://metacpan.org/pod/release/ETHER/Moose-2.1106-TRIAL/lib/Moose/Manual/Delta.pod#pod2.1200 We recommend that you take a look at your code to see if it indeed does need to be updated with respect to the latest Moose release, 2.1106-TRIAL. If you have any questions, then please ask either on Moose mailing list : http://lists.perl.org/list/moose.html or on #moose & #moose-dev on irc.perl.org.

Sat Nov 23 12:07:46 2013 ether [...] cpan.org - Reference by ticket #90657 added

Tue Jan 21 21:14:50 2014 cpan [...] zoffix.com - Correspondence added

Attached patch fixes this issue. -- Cheers, ZZ [ https://metacpan.org/author/ZOFFIX ]

Subject:

helm.moose.enum.patch

diff -Naur helm-0.4_orig/lib/Helm/Log.pm helm-0.4/lib/Helm/Log.pm --- helm-0.4_orig/lib/Helm/Log.pm 2014-01-21 21:11:02.628527036 -0500 +++ helm-0.4/lib/Helm/Log.pm 2014-01-21 21:11:37.632527494 -0500 @@ -5,7 +5,7 @@ use Moose::Util::TypeConstraints qw(enum); use namespace::autoclean; -enum LOG_LEVEL => qw(debug info warn error); +enum LOG_LEVEL => [qw(debug info warn error)]; has channels => ( is => 'ro', writer => '_channels', diff -Naur helm-0.4_orig/lib/Helm.pm helm-0.4/lib/Helm.pm --- helm-0.4_orig/lib/Helm.pm 2014-01-21 21:11:02.628527036 -0500 +++ helm-0.4/lib/Helm.pm 2014-01-21 21:11:26.028527342 -0500 @@ -23,8 +23,8 @@ our $DEBUG_LOG; our $DEBUG_LOG_PID; -enum LOG_LEVEL => qw(debug info warn error); -enum LOCK_TYPE => qw(none local remote both); +enum LOG_LEVEL => [qw(debug info warn error)]; +enum LOCK_TYPE => [qw(none local remote both)]; has task => (is => 'ro', writer => '_task', required => 1); has user => (is => 'ro', writer => '_user', isa => 'Maybe[Str]');

Tue Jan 21 21:14:50 2014 The RT System itself - Status changed from 'new' to 'open'