Bug #90601 for App-cpanminus-reporter: deep recursion

Thu Nov 21 14:59:48 2013 ether [...] cpan.org - Ticket created

Subject:

deep recursion

While sending a bunch of reports (after a new perl install, so there were a *lot* of modules that I installed in one go), I saw this several times: Deep recursion on anonymous subroutine at /Users/ether/.perlbrew/libs/19.5@std/lib/perl5/App/cpanminus/reporter.pm line 206, <$fh> line 24837.

Fri Dec 20 19:02:47 2013 ether [...] cpan.org - Correspondence added

I just ran into this again when installing lots of things with perl 5.19.7: Deep recursion on anonymous subroutine at /Users/ether/.perlbrew/libs/19.7@std/lib/perl5/App/cpanminus/reporter.pm line 206, <$fh> line 40930. I cannot haz reports? :(

Tue Mar 18 02:22:15 2014 garu [...] cpan.org - Correspondence added

Hi ether! the parser is recursive indeed, and I agree 100 (perl's limit) might be a bit too short of a limit, specially to cover tons of nested deps such as on clean builds. I'll wrap the parser under a "no warnings 'recursion'" and see how it goes. I'd still feel more comfortable with some limit, though. How about you send me a faulty build.log (one that triggers the message) and I add it to the tests and use it to set a new limit? Thanks!

Tue Mar 18 02:22:15 2014 The RT System itself - Status changed from 'new' to 'open'

Mon May 26 13:59:40 2014 ether [...] cpan.org - Correspondence added

On 2014-03-17 23:22:15, GARU wrote: Show quoted text

> Hi ether! > > the parser is recursive indeed, and I agree 100 (perl's limit) might > be a bit too short of a limit, specially to cover tons of nested deps > such as on clean builds. I'll wrap the parser under a "no warnings > 'recursion'" and see how it goes. > > I'd still feel more comfortable with some limit, though. How about you > send me a faulty build.log (one that triggers the message) and I add > it to the tests and use it to set a new limit? > > Thanks!

I was able to reproduce this again, with a fresh 5.20.0 build! \o/ Attached is the build log (1.9MB!) /Users/ether/.cpanm/work/1401124766.32545/build.log

Subject:

build.log

Download build.log
application/octet-stream 1.8m

Message body not shown because it is not plain text.

Mon May 26 14:01:06 2014 ether [...] cpan.org - Correspondence added

Message body is not shown because it is too large.

Tue Jun 24 18:33:21 2014 garu [...] cpan.org - Correspondence added

Thanks! I'm trying to turn your log into a test case, but right now it just takes too long to run so I just shipped v0.11 with just the fix, not the test for it. Hopefully I'll get to the proper test soon. But it's fixed! :)

Tue Jun 24 18:33:23 2014 garu [...] cpan.org - Status changed from 'open' to 'resolved'