Bug #90487 for Net-Async-IRC: Nick change not properly set when connecting and getting an ERR

Mon Nov 18 12:19:25 2013 andreas.guldstrand [...] gmail.com - Ticket created

Subject:	Nick change not properly set when connecting and getting an ERR_NICKINUSE
Date:	Mon, 18 Nov 2013 18:19:13 +0100
To:	bug-Net-Async-IRC [...] rt.cpan.org
From:	Andreas Guldstrand <andreas.guldstrand [...] gmail.com>

<pink_mist> LeoNerd: I've got a problem with Net::Async::IRC ... if I connect to a server and the nick I want to use is already in use, I get an ERR_NICKINUSE, and can issue a new change_nick using a different nickname .. however that nick isn't "set" since https://metacpan.org/source/PEVANS/Net-Async-IRC-0.07/lib/Net/Async/IRC.pm#L353 doesn't realize that the prefix can be empty if the server hasn't actually given you a nick yet <LeoNerd> Define "that nick isn't set" <pink_mist> $self->_set_nick( $hints->{new_nick} ); <-- is never called

Mon Nov 18 12:29:55 2013 andreas.guldstrand [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #90487] AutoReply: Nick change not properly set when connecting and getting an ERR_NICKINUSE
Date:	Mon, 18 Nov 2013 18:29:42 +0100
To:	bug-Net-Async-IRC [...] rt.cpan.org
From:	Andreas Guldstrand <andreas.guldstrand [...] gmail.com>

Damn gmail compose box making me format the text horribly wrong, this should be more readable ... I hope <pink_mist> LeoNerd: I've got a problem with Net::Async::IRC ... if I connect to a server and the nick I want to use is already in use, I get an ERR_NICKINUSE, and can issue a new change_nick using a different nickname .. however that nick isn't "set" since https://metacpan.org/source/PEVANS/Net-Async-IRC-0.07/lib/Net/Async/IRC.pm#L353doesn't realize that the prefix can be empty if the server hasn't actually given you a nick yet <LeoNerd> Define "that nick isn't set" <pink_mist> $self->_set_nick( $hints->{new_nick} ); <-- is never called

Wed Nov 20 07:28:25 2013 andreas.guldstrand [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #90487] AutoReply: Nick change not properly set when connecting and getting an ERR_NICKINUSE [PATCH]
Date:	Wed, 20 Nov 2013 13:28:15 +0100
To:	bug-Net-Async-IRC [...] rt.cpan.org
From:	Andreas Guldstrand <andreas.guldstrand [...] gmail.com>

I've created a patch that seems to fix the problem for me; tests included!

Message body is not shown because sender requested not to inline it.

Mon Jan 20 12:51:09 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Thanks; patch now applied in latest source. Will be in next version. -- Paul Evans

Mon Jan 20 12:51:09 2014 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 20 12:51:10 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'

Tue Jan 21 19:49:03 2014 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Released in 0.09 -- Paul Evans

Tue Jan 21 19:49:04 2014 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Tue Jan 21 19:49:05 2014 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.09 added

Bug #90487 for Net-Async-IRC: Nick change not properly set when connecting and getting an ERR_NICKINUSE