Skip Menu |

This queue is for tickets about the DB_File CPAN distribution.

Report information
The Basics
Id: 90383
Status: resolved
Priority: 0/
Queue: DB_File
People
Owner: Nobody in particular
Requestors: HMBRAND [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 1.830
Fixed in: 1.831

History Show all quoted text
  Fri Nov 15 04:02:28 2013 HMBRAND [...] cpan.org - Ticket created
Subject: C99 comment is a nogo
Already fixed in blead http://perl5.git.perl.org/perl.git/commit/1b7c306550e17237aec242cbef7ad7c3fdbd16f5 commit 1b7c306550e17237aec242cbef7ad7c3fdbd16f5 Author: H.Merijn Brand <h.m.brand@xs4all.nl> Date: Thu Nov 14 12:53:03 2013 +0100 NO C99 comments, please! diff --git a/cpan/DB_File/DB_File.xs b/cpan/DB_File/DB_File.xs index 83ba736..679c416 100644 --- a/cpan/DB_File/DB_File.xs +++ b/cpan/DB_File/DB_File.xs @@ -1498,7 +1498,7 @@ SV * sv ; if (status) { - db_close(RETVAL); // close **dbp handle to prevent mem.leak + db_close(RETVAL); /* close **dbp handle to prevent mem.leak */ RETVAL->dbp = NULL ; }
  Fri Nov 15 17:53:53 2013 pmqs [...] cpan.org - Correspondence added
Good catch. Uploaded fixed version to CPAN. Paul
  Fri Nov 15 17:53:53 2013 The RT System itself - Status changed from 'new' to 'open'
  Sat Nov 16 09:12:53 2013 pmqs [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Nov 16 09:12:53 2013 pmqs [...] cpan.org - Fixed in 1.831 added