Bug #90341 for DBIx-Class-Schema-Loader: Generated sequence name is incorrect for Oracle

Wed Nov 13 16:14:57 2013 dlove [...] us.ntt.net - Ticket created

Subject:	Generated sequence name is incorrect for Oracle
Date:	Wed, 13 Nov 2013 14:14:40 -0700
To:	bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From:	David Love <dlove [...] us.ntt.net>

The generated sequence name for Oracle is always set to the last character in the actual sequence name. The regex checks for schema.sequence, then splits the portion after the period (i.e., the sequence) into two parts and uses the last portion as the sequence name. So given a trigger with sequence “myschema.mysequence”, the code generates: sequence => “e” DBIx::Class::Schema::Loader 0.07037 perl -v: This is perl 5, version 12, subversion 5 (v5.12.5) built for sun4-solaris-64-ld uname -a: SunOS gnomedev1.it.ntta.com 5.10 Generic_147440-15 sun4v sparc SUNW,SPARC-Enterprise-T5220 Replicated in OSX/Mavericks: Darwin elrond.local 13.0.0 Darwin Kernel Version 13.0.0: Thu Sep 19 22:22:27 PDT 2013; root:xnu-2422.1.72~6/RELEASE_X86_64 x86_64

Sun Nov 17 09:34:38 2013 ilmari [...] ilmari.org - Correspondence added

CC:	undisclosed-recipients:;
Subject:	Re: [rt.cpan.org #90341] Generated sequence name is incorrect for Oracle
Date:	Sun, 17 Nov 2013 15:34:10 +0100
To:	bug-DBIx-Class-Schema-Loader [...] rt.cpan.org
From:	ilmari [...] ilmari.org (Dagfinn Ilmari Mannsåker)

"David Love via RT" <bug-DBIx-Class-Schema-Loader@rt.cpan.org> writes: Show quoted text

> The generated sequence name for Oracle is always set to the last > character in the actual sequence name. The regex checks for > schema.sequence, then splits the portion after the period (i.e., the > sequence) into two parts and uses the last portion as the sequence > name. > > So given a trigger with sequence “myschema.mysequence”, the code generates: > > sequence => “e”

I've fixed the regex in the ora-seq-schema-rt90341 branch in git, but I'm not sure about the test change. Could you please check out the branch and run the tests with the DBICTEST_ORA_{DSN,USER,PASS} and DBICTEST_ORA_EXTRAUSER_{DSN,USER,PASS} environment variables set appropriately? If you don't already have a checkout handy, do: git clone https://github.com/dbsrgits/dbix-class-schema-loader.git cd dbix-class-schema-loader git checkout -t origin/ora-seq-schema-rt90341 to get the code. -- - Twitter seems more influential [than blogs] in the 'gets reported in the mainstream press' sense at least. - Matt McLeod - That'd be because the content of a tweet is easier to condense down to a mainstream media article. - Calle Dybedahl

Sun Nov 17 09:34:39 2013 The RT System itself - Status changed from 'new' to 'open'

Tue Nov 19 13:49:43 2013 ilmari+cpan [...] ilmari.org - Correspondence added

I managed to get Oracle XE and DBD::Oracle installed, so I've now fixed the tests (including several unrelated errors), and merged this to master¹, so it'll be in the next release. [1] https://github.com/dbsrgits/dbix-class-schema-loader/commit/1de9c8e18dde9ef2accda369fe8616c230583eb2

Tue Nov 19 13:49:45 2013 ilmari+cpan [...] ilmari.org - Status changed from 'open' to 'patched'

Wed Nov 20 06:56:33 2013 ilmari+cpan [...] ilmari.org - Correspondence added

Version 0.07038 has now been released to CPAN.

Wed Nov 20 06:56:36 2013 ilmari+cpan [...] ilmari.org - Status changed from 'patched' to 'resolved'