Bug #89954 for Tk-TOTD: I think I found a bug in Tk-TOTD-0.20

Fri Nov 01 16:31:21 2013 Daniel.Richards [...] onsemi.com - Ticket created

Subject:	I think I found a bug in Tk-TOTD-0.20
Date:	Fri, 1 Nov 2013 20:31:03 +0000
To:	"bug-Tk-TOTD [...] rt.cpan.org" <bug-Tk-TOTD [...] rt.cpan.org>
From:	Daniel Richards <Daniel.Richards [...] onsemi.com>

I am using Linux on a 2.6.18 kernel (yeah, it's old. It's a work computer), Perl 5.16.0 and Tk-TOTD-0.20<http://search.cpan.org/%7Ekirsle/Tk-TOTD-0.20/>. I found that a program using Tk::TOTD doesn't want to give control back to the shell used to call the program, and I have to Ctrl-c the program. In addition, with Ctrl-c, I am unable to verify if the check button actually does anything. The following code produces the error. I posted this on Perlmonks (in node http://www.perlmonks.org/?node_id=1060803, in case you were curious) and at least one other also reproduced it. #!/usr/bin/env perl use strict; use warnings; use utf8; use Tk; use Tk::TOTD; my $mw = MainWindow->new; my $label = $mw->Label( -text => 'hi!')->pack; my $entry = $mw->Entry()->pack; my $button = $mw->Button( -text => 'push me!')->pack; my @messages = ( 'message 1', 'message 2', 'message 3'); my $totd = $mw->TOTD ( -title => 'Tip Of The Day', -messages => \@messages); $totd->Show; MainLoop; Daniel Richards Intern ON Semiconductor Corp R&D Integration Email: daniel.richards@onsemi.com Work: 208-233-4690 x6316

Fri Nov 01 17:06:17 2013 kirsle [...] cpan.org - Correspondence added 20 min

Confirmed bug. The problem is reproduced when you use the in-dialog "Close" button to dismiss the dialog. Clicking your window manager's "X" button doesn't reproduce the problem. The root cause is that the "Close" button calls destroy() on the dialog, and the underlying DialogBox doesn't like this, because it calls WaitVariable and waits forever. Instead, I set the "selected_button" attribute of the DialogBox, which causes the DialogBox to close itself gracefully. See: https://github.com/kirsle/Tk-TOTD/commit/8fa6e2131beb9bfba0cdf915d0af6b10134e5181 I've uploaded Tk::TOTD 0.3 to CPAN that fixes this issue.

Fri Nov 01 17:06:17 2013 The RT System itself - Status changed from 'new' to 'open'

Fri Nov 01 17:06:17 2013 kirsle [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Nov 01 17:06:18 2013 kirsle [...] cpan.org - Taken

Fri Nov 01 17:25:58 2013 Daniel.Richards [...] onsemi.com - Correspondence added

Subject:	RE: [rt.cpan.org #89954] Resolved: I think I found a bug in Tk-TOTD-0.20
Date:	Fri, 1 Nov 2013 21:25:26 +0000
To:	"bug-Tk-TOTD [...] rt.cpan.org" <bug-Tk-TOTD [...] rt.cpan.org>
From:	Daniel Richards <Daniel.Richards [...] onsemi.com>

Thank you for taking care of that quickly. I do have another question though. How long does it take for the changes to percolate through cpan.org and the cpan mirrors? Daniel Richards Intern ON Semiconductor Corp R&D Integration Email: daniel.richards@onsemi.com Work: 208-233-4690 x6316 Show quoted text

-----Original Message----- From: Casey Kirsle via RT [mailto:bug-Tk-TOTD@rt.cpan.org] Sent: Friday, November 01, 2013 3:06 PM To: Daniel Richards Subject: [rt.cpan.org #89954] Resolved: I think I found a bug in Tk-TOTD-0.20 <URL: https://rt.cpan.org/Ticket/Display.html?id=89954 > According to our records, your request has been resolved. If you have any further questions or concerns, please respond to this message.

Fri Nov 01 17:50:49 2013 kirsle [...] cpan.org - Correspondence added

A few hours, usually. You can get the code now from github directly: https://github.com/kirsle/Tk-TOTD (there's a "Download ZIP" button on the right if you don't have git setup locally).

Fri Nov 01 17:54:44 2013 Daniel.Richards [...] onsemi.com - Correspondence added

Subject:	RE: [rt.cpan.org #89954] I think I found a bug in Tk-TOTD-0.20
Date:	Fri, 1 Nov 2013 21:54:30 +0000
To:	"bug-Tk-TOTD [...] rt.cpan.org" <bug-Tk-TOTD [...] rt.cpan.org>
From:	Daniel Richards <Daniel.Richards [...] onsemi.com>

Ah, thanks. I tried to install it, and I was going to say it didn't work, but I guess it did :) . Now I just have to figure out how to use the check box, but that should be easy. Thanks again. Daniel Richards Intern ON Semiconductor Corp R&D Integration Email: daniel.richards@onsemi.com Work: 208-233-4690 x6316 Show quoted text

-----Original Message----- From: Casey Kirsle via RT [mailto:bug-Tk-TOTD@rt.cpan.org] Sent: Friday, November 01, 2013 3:51 PM To: Daniel Richards Subject: [rt.cpan.org #89954] I think I found a bug in Tk-TOTD-0.20 <URL: https://rt.cpan.org/Ticket/Display.html?id=89954 > A few hours, usually. You can get the code now from github directly: https://github.com/kirsle/Tk-TOTD (there's a "Download ZIP" button on the right if you don't have git setup locally).

Fri Nov 01 18:20:21 2013 kirsle [...] cpan.org - Correspondence added

The -checkvariable option is the one you want. $mw->TOTD(-checkvariable => \$is_checked); It works just like the -variable option of Tk::Checkbutton.

Fri Nov 01 18:24:38 2013 Daniel.Richards [...] onsemi.com - Correspondence added

Subject:	RE: [rt.cpan.org #89954] I think I found a bug in Tk-TOTD-0.20
Date:	Fri, 1 Nov 2013 22:24:27 +0000
To:	"bug-Tk-TOTD [...] rt.cpan.org" <bug-Tk-TOTD [...] rt.cpan.org>
From:	Daniel Richards <Daniel.Richards [...] onsemi.com>

Thanks. I eventually arrived at that, but thanks for confirming that. Daniel Richards Intern ON Semiconductor Corp R&D Integration Email: daniel.richards@onsemi.com Work: 208-233-4690 x6316 Show quoted text

-----Original Message----- From: Casey Kirsle via RT [mailto:bug-Tk-TOTD@rt.cpan.org] Sent: Friday, November 01, 2013 4:20 PM To: Daniel Richards Subject: [rt.cpan.org #89954] I think I found a bug in Tk-TOTD-0.20 <URL: https://rt.cpan.org/Ticket/Display.html?id=89954 > The -checkvariable option is the one you want. $mw->TOTD(-checkvariable => \$is_checked); It works just like the -variable option of Tk::Checkbutton.