Skip Menu |

This queue is for tickets about the Image-Scale CPAN distribution.

Report information
The Basics
Id: 89927
Status: resolved
Priority: 0/
Queue: Image-Scale

People
Owner: AGRUNDMA [...] cpan.org
Requestors: andreas.marienborg [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.08
Fixed in: (no value)



Subject: Problems on mac os x 10.9 with libpng1.5(.14)
I had issues getting Image::Scale to work. The first one is probably mostly cosmetic, it just emits some warnings about non-existing paths. The second (libpng 1.5) results in compilation failures. png_memcpy no longer exists in libpng 1.5. I couldn't find out if there was another proper replacement, but changing to just memcpy made it compile and the tests pass at least :P
Subject: patch01-osx9-libpng15.patch
diff --git a/hints/darwin.pl b/hints/darwin.pl index ff9eabd..44cf8eb 100644 --- a/hints/darwin.pl +++ b/hints/darwin.pl @@ -17,8 +17,12 @@ if ( $Config{myarchname} =~ /i386/ ) { # Read OS version my $sys = `/usr/sbin/system_profiler SPSoftwareDataType`; - my ($osx_ver) = $sys =~ /Mac OS X.*(10\.[^ ]+)/; - if ( $osx_ver gt '10.5' ) { + my ($osx_ver) = $sys =~ /(?:Mac |)OS X.*(10\.[^ ]+)/; + warn $osx_ver; + if ( $osx_ver ge '10.9' ) { + + } + elsif ( $osx_ver gt '10.5' ) { # Running 10.6+, build as 10.5+ $arch .= "-isysroot /Developer/SDKs/MacOSX10.5.sdk -mmacosx-version-min=10.5"; } diff --git a/src/png.c b/src/png.c index bb4574c..293661e 100644 --- a/src/png.c +++ b/src/png.c @@ -40,7 +40,7 @@ image_png_read_buf(png_structp png_ptr, png_bytep data, png_size_t len) } } - png_memcpy(data, buffer_ptr(im->buf), len); + memcpy(data, buffer_ptr(im->buf), len); buffer_consume(im->buf, len); goto ok;
the following patch fixes this for os x 10.11 (And I think 10.10) as well. It is meant to apply after the previous patch
Subject: 0001-Update-for-OS-X-10.10-and-10.11.patch
From 61d72e2006ce6bba6c15145c18a4dd3e4c6bbd9a Mon Sep 17 00:00:00 2001 From: Andreas Marienborg <omega@palle.net> Date: Wed, 5 Aug 2015 16:02:20 +0700 Subject: [PATCH] Update for OS X 10.10 and 10.11 --- hints/darwin.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hints/darwin.pl b/hints/darwin.pl index 44cf8eb..8ba6c0e 100644 --- a/hints/darwin.pl +++ b/hints/darwin.pl @@ -19,7 +19,7 @@ if ( $Config{myarchname} =~ /i386/ ) { my $sys = `/usr/sbin/system_profiler SPSoftwareDataType`; my ($osx_ver) = $sys =~ /(?:Mac |)OS X.*(10\.[^ ]+)/; warn $osx_ver; - if ( $osx_ver ge '10.9' ) { + if ( $osx_ver ge '10.9' or $osx_ver gt "10.10" and $osv_ver lt "10.30" ) { } elsif ( $osx_ver gt '10.5' ) { -- 2.5.0
Thanks, this should be fixed in version 0.10.