Bug #89697 for CHI-Driver-Memcached: fails with Cache::Memcached::libmemcached installed

Tue Oct 22 09:26:55 2013 zefram [...] fysh.org - Ticket created

Subject:	fails with Cache::Memcached::libmemcached installed
Date:	Tue, 22 Oct 2013 14:26:28 +0100
To:	bug-CHI-Driver-Memcached [...] rt.cpan.org
From:	Zefram <zefram [...] fysh.org>

Message body is not shown because it is too large.

Wed May 20 07:17:40 2015 TIMB [...] cpan.org - Correspondence added

I've just hit this as well. Any news?

Wed May 20 07:17:41 2015 The RT System itself - Status changed from 'new' to 'open'

Wed May 20 09:25:52 2015 swartz [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #89697] fails with Cache::Memcached::libmemcached installed
Date:	Wed, 20 May 2015 06:25:39 -0700
To:	bug-CHI-Driver-Memcached [...] rt.cpan.org
From:	Jonathan Swartz <swartz [...] pobox.com>

I haven’t been in the Perl world for years, but I’m happy to release a patch / pull request. I did try to install libmemcached on my mac to test this, but ran into https://github.com/Homebrew/homebrew/issues/20635. I’ll see if that goes away when I upgrade to Yosemite. On May 20, 2015, at 4:17 AM, Tim_Bunce via RT <bug-CHI-Driver-Memcached@rt.cpan.org> wrote: Show quoted text

> Queue: CHI-Driver-Memcached > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=89697 > > > I've just hit this as well. Any news?

Thu May 21 09:39:09 2015 TIMB [...] cpan.org - Correspondence added

The failures look like: t/CHIDriverTests-libmemcached.t .. 1/? # Failed test 'cache2 untouched by clear' # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1178. # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_clear) # Comparing $data as a Set # Missing: '0', '1', 'a', 'abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab', 'arrayref', 'binary', 'empty', 'hashref', 'medium', 'mixed', 'newline', 'space', 'utf8' t/CHIDriverTests-libmemcached.t .. 71/? # Failed test '5 lowest' # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1502. # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) # Comparing $data as a Set # Missing: 'key0', 'key1', 'key2', 'key3', 'key4' # Failed test '1 lowest' # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1506. # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) # Comparing $data as a Set # Missing: 'key0' # Failed test '5 lowest' # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1502. # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) # Comparing $data as a Set # Missing: 'key0', 'key1', 'key2', 'key3', 'key4' # Failed test '1 lowest' # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1506. # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) # Comparing $data as a Set # Missing: 'key0' # Failed test '5 lowest' # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1502. # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) # Comparing $data as a Set # Missing: 'key0', 'key1', 'key2', 'key3', 'key4' ... Any clues as to the likely cause would be appreciated.

Thu May 21 12:46:53 2015 swartz [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #89697] fails with Cache::Memcached::libmemcached installed
Date:	Thu, 21 May 2015 09:46:40 -0700
To:	bug-CHI-Driver-Memcached [...] rt.cpan.org
From:	Jonathan Swartz <swartz [...] pobox.com>

Can you see if they pass for Cache::Memcached? On May 21, 2015, at 6:39 AM, Tim_Bunce via RT <bug-CHI-Driver-Memcached@rt.cpan.org> wrote: Show quoted text

> Queue: CHI-Driver-Memcached > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=89697 > > > The failures look like: > > t/CHIDriverTests-libmemcached.t .. 1/? > # Failed test 'cache2 untouched by clear' > # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1178. > # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_clear) > # Comparing $data as a Set > # Missing: '0', '1', 'a', 'abababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababababab', 'arrayref', 'binary', 'empty', 'hashref', 'medium', 'mixed', 'newline', 'space', 'utf8' > t/CHIDriverTests-libmemcached.t .. 71/? > # Failed test '5 lowest' > # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1502. > # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) > # Comparing $data as a Set > # Missing: 'key0', 'key1', 'key2', 'key3', 'key4' > > # Failed test '1 lowest' > # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1506. > # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) > # Comparing $data as a Set > # Missing: 'key0' > > # Failed test '5 lowest' > # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1502. > # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) > # Comparing $data as a Set > # Missing: 'key0', 'key1', 'key2', 'key3', 'key4' > > # Failed test '1 lowest' > # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1506. > # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) > # Comparing $data as a Set > # Missing: 'key0' > > # Failed test '5 lowest' > # at /home/tim/trunk/cpan/cpan-5.010/lib/perl5/CHI/t/Driver.pm line 1502. > # (in CHI::Driver::Memcached::t::CHIDriverTests::libmemcached->test_custom_discard_policy) > # Comparing $data as a Set > # Missing: 'key0', 'key1', 'key2', 'key3', 'key4' > > ... > > Any clues as to the likely cause would be appreciated.

Tue Jun 02 09:21:31 2015 TIMB [...] cpan.org - Correspondence added

Sorry for the delay. I'd missed your reply. Yes, t/CHIDriverTests-Memcached.t and t/CHIDriverTests-Fast.t pass, but t/CHIDriverTests-libmemcached.t fails. Here's a full log: https://gist.github.com/timbunce/a6876a6aa0ec321655dd Given the way the tests are structure it does seem mostly likely that the bug is in Cache::Memcached::libmemcached and/or Memcached::libmemcached. What really puzzles me is that I can't find some combination of Cache::Memcached::libmemcached and Memcached::libmemcached that passes the test. So the first question is can you reproduce the problem? Also, can you confirm that you would have had Cache::Memcached::libmemcached installed and so would have tested CHI::Driver::Memcached with it before release? Any idea what versions you would have used? And finally, looking at the specific failures, could you guess at the likely cause? Thanks!

Sat Jun 06 19:54:15 2015 swartz [...] pobox.com - Correspondence added

Subject:	Re: [rt.cpan.org #89697] fails with Cache::Memcached::libmemcached installed
Date:	Sat, 6 Jun 2015 16:53:57 -0700
To:	bug-CHI-Driver-Memcached [...] rt.cpan.org
From:	Jonathan Swartz <swartz [...] pobox.com>

I can’t even get libmemcached compiled on my mac, so no can’t reproduce the problem. :) I’d be surprised if these tests never passed and we never heard about it - they’ve been around for years - but I guess it’s possible… From the test failures it looks like it might have something to do with get_keys. This isn’t supported in memcached of course, but the test class defines a simulated get_keys for the purposes of testing. Looks like maybe this isn’t working for libmemcached. On Jun 2, 2015, at 6:21 AM, Tim_Bunce via RT <bug-CHI-Driver-Memcached@rt.cpan.org> wrote: Show quoted text

> Queue: CHI-Driver-Memcached > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=89697 > > > Sorry for the delay. I'd missed your reply. > > Yes, t/CHIDriverTests-Memcached.t and t/CHIDriverTests-Fast.t pass, but t/CHIDriverTests-libmemcached.t fails. > Here's a full log: https://gist.github.com/timbunce/a6876a6aa0ec321655dd > > Given the way the tests are structure it does seem mostly likely that the bug is in Cache::Memcached::libmemcached and/or Memcached::libmemcached. > > What really puzzles me is that I can't find some combination of Cache::Memcached::libmemcached and Memcached::libmemcached that passes the test. > > So the first question is can you reproduce the problem? > > Also, can you confirm that you would have had Cache::Memcached::libmemcached installed and so would have tested CHI::Driver::Memcached with it before release? > > Any idea what versions you would have used? > > And finally, looking at the specific failures, could you guess at the likely cause? > > Thanks!

Wed Jun 24 07:19:02 2015 TIMB [...] cpan.org - Correspondence added

I've reproduced our previous successful setup: cpanm https://cpan.metacpan.org/authors/id/T/TI/TIMB/Memcached-libmemcached-0.4405.tar.gz cpanm https://cpan.metacpan.org/authors/id/T/TI/TIMB/Cache-Memcached-libmemcached-0.02011.tar.gz cpanm https://cpan.metacpan.org/authors/id/J/JS/JSWARTZ/CHI-Driver-Memcached-0.14.tar.gz So now I'm going to "walk forward" to see which version of which distro triggers the failure.

Wed Jun 24 09:55:17 2015 TIMB [...] cpan.org - Correspondence added

CHI-Driver-Memcached-0.16 installed ok with the old modules, so we know the failure isn't due to new/changed tests. CHI-Driver-Memcached-0.16 installed ok after upgrading to Cache-Memcached-libmemcached 0.03001 (not 0.04001 as that requires a recent Memcached-libmemcached version, though probably doesn't really _need_ it.) CHI-Driver-Memcached-0.16 tests failed after upgrading Memcached-libmemcached from 0.4406 to any later version I tried. Confirmed with perl 5.10.1 and perl 5.20.2.

Wed Jun 24 09:56:39 2015 TIMB [...] cpan.org - Correspondence added

So, in summary, this appears to be a bug in Memcached::libmemcached v1+ that's exposed by the torture test suite of CHI::Driver::Memcached.

Sun Apr 24 10:13:39 2016 wolfsage [...] gmail.com - Correspondence added

From:

wolfsage [...] gmail.com

On Wed Jun 24 09:56:39 2015, TIMB wrote: Show quoted text

> So, in summary, this appears to be a bug in Memcached::libmemcached > v1+ that's exposed by the torture test suite of > CHI::Driver::Memcached.

I think I've finally got it: https://github.com/jonswar/perl-chi-driver-memcached/pull/2 Newer libmemcached doesn't like keys with no length. Previous versions of libmemcached would prepend the namespace to a zero length key before submitting it to memcached. Now it just returns an error, so don't attempt to call get_multi() with such keys. -- Matthew Horsfall (alh)